Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71B4C4332F for ; Mon, 20 Dec 2021 23:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231809AbhLTXav (ORCPT ); Mon, 20 Dec 2021 18:30:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbhLTXau (ORCPT ); Mon, 20 Dec 2021 18:30:50 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93EF1C061574; Mon, 20 Dec 2021 15:30:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29A0961307; Mon, 20 Dec 2021 23:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63898C36AE5; Mon, 20 Dec 2021 23:30:48 +0000 (UTC) Date: Mon, 20 Dec 2021 18:30:46 -0500 From: Steven Rostedt To: Jens Axboe Cc: Wander Costa , Wander Lairson Costa , open list , Ingo Molnar , "open list:BLOCK LAYER" , Thomas Gleixner , Sebastian Andrzej Siewior Subject: Re: [PATCH v5 1/1] blktrace: switch trace spinlock to a raw spinlock Message-ID: <20211220183046.7193720d@rorschach.local.home> In-Reply-To: <76333783-cb3a-d1b7-5e40-d07014c4e2c0@kernel.dk> References: <20211220192827.38297-1-wander@redhat.com> <8340efc7-f922-fb8c-772c-de72cefe3470@kernel.dk> <2f2f5003-e1bf-15ce-32cd-a543634ba880@kernel.dk> <76333783-cb3a-d1b7-5e40-d07014c4e2c0@kernel.dk> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Dec 2021 13:49:47 -0700 Jens Axboe wrote: > Alright, fair enough, mistakes happen. I think the patch looks fine, my > main dislike is that it's Yet Another things that needs special RT > handling. But I guess that's how it is... It's not really "yet another thing". That's because in general tracing needs special RT handling (and a lot of other special handling, not just RT). blktrace falls under the tracing category, and this just falls under one more thing to make tracing work with RT. -- Steve