From:   Li Chen <lchen@ambarella.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>
Subject: [PATCH] PCI: endpoint: set_msi: return -EINVAL when interrupts num is
 smaller than 1
Thread-Topic: [PATCH] PCI: endpoint: set_msi: return -EINVAL when interrupts
 num is smaller than 1
Thread-Index: Adf2FiFmswPDWB/WQWCvxXrOLCbdxA==
Date:   Tue, 21 Dec 2021 02:59:56 +0000
Message-ID: <CH2PR19MB402491B9E503694DBCAC6005A07C9@CH2PR19MB4024.namprd19.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?jX4FuxxvCcmV3Ilm05djkB5EHwvy6kvBYeqyLLyqy4tQrp5ormnvadaqg2?=
 =?iso-8859-2?Q?gYtgJOlnDFMh6ynmaQ0dTn5DdvAmWElCnWhwaR3FkOYsAbJxEKDxYFNnH/?=
 =?iso-8859-2?Q?S2FKo4VvLUhoFb15MjF9EIMEh8AltnXXtZkYUCuo3G8lrBLvGdMNHrqZZP?=
 =?iso-8859-2?Q?o9UMk29PaTaqnypmQa/WZhhFnEVyenCy2i+m8kGlNfoT3E+W/jmxpYHNG2?=
 =?iso-8859-2?Q?ttSqpWptNPB1i50qXqH+Vd5wtsIL8zFMXYtoB9OG4t22vOLQYFS/NfNpox?=
 =?iso-8859-2?Q?ppQV2fwJHHixxwSrXG8o+9N5/QaEBUOtRG0L3AqVimS1CWWchxGSOXpKJa?=
 =?iso-8859-2?Q?Y53Xdx5lqvgSnEM0aVqOORGNJsJzzI8DU23N7Gap6mBAotQvntAqxD92L7?=
 =?iso-8859-2?Q?PlplGaZHToXULmlN2FCiWvR817heIFiYyx9U6a8jZ6K1kEUR1iH90Lcq1T?=
 =?iso-8859-2?Q?ud/TIGv3CB/4lDkJ5EKYj0IC3vB6KIL/vGWVEg2W35fClKaqLheHxIi7tB?=
 =?iso-8859-2?Q?IimkcSZJCi5c/HX3E8EsZGbNNluxUFkMe2TyAP5mZGR4m23WGmGCFaZcr9?=
 =?iso-8859-2?Q?5Je3BnhH92w76mz07/ud1TmYuXImY6MNUC7T4eetQGk7GK5lyK/FyTUqtv?=
 =?iso-8859-2?Q?fsQdVEzGxeSSBKYpYm63+v+LxZ7ZsAyGaRjgUdSuqSAOFlE6qK0V8kwSKh?=
 =?iso-8859-2?Q?dtxqVrpDcSDqI/4GupVuwq/DllpWHKvNywxuRmwXo8Qag7ptqsdyEW9t8+?=
 =?iso-8859-2?Q?SpODsSInAVUfp1B+sjne5qFpBBIVMVOh8FREVhqk6e+1/znaA9LLQWVqWC?=
 =?iso-8859-2?Q?79yayO7kYzbCNKzlEzq6OweL3zaOHL4/E6f4qpE49CEDUuW1/lQ7uj4IAA?=
 =?iso-8859-2?Q?vHsw7NPC+ixRRRwFTo4TRCNdK37ixSVgOiJZWYqMncgyjQiU86ZO9zYj4X?=
 =?iso-8859-2?Q?UnckcrJV8WQpK4B0Fly2PyEI/kGAZTMVtd8+2VUlcytmR2gJqpL5lrzTe8?=
 =?iso-8859-2?Q?bXmC7LdGOfkJZb3nV4ZUYaLQN15V+sRtAn3nvbH7ntp19E5ZEETyu9vjE8?=
 =?iso-8859-2?Q?RZPtwWGsu7ntI53GKP7ejXcEn1bcHRz9QD1zFsfE9eRnWUvQiIZHTCsc06?=
 =?iso-8859-2?Q?ij8g0um/JMeP+KYn5k4O0d4Jz93gel+WHbD5neFJpACGZAXukxDZvSGVyv?=
 =?iso-8859-2?Q?AdKxxDhI+OLu9OppdH9fPLAE2/tM8IMduDtOCoqGDsCENNt1rsPlh5lN6G?=
 =?iso-8859-2?Q?Y3NT8WWTixdksykMEBeF6FsoahZdrC6jmTG+gfVN4r4tLPl0qcUwMUVdQB?=
 =?iso-8859-2?Q?nZDzUoI/09eVoNGp4QlipUipRmtqFu7qB9Ae/e+X5y4iu9WIBsOVpmoYOQ?=
 =?iso-8859-2?Q?i+iFK6VJQSn7xkqu5NMxKIXOsR43QEkCEdOMPxAQzsX5rKQIjifGC1qYbJ?=
 =?iso-8859-2?Q?hAzwFRSB2K8hwjbDd9dKOxSvBgnHtzTD1QVJm8nHq+oUSQBKtlKjX/qXk8?=
 =?iso-8859-2?Q?Q3zlcGDbCZ/E3QPvokJIpvp3e8ECktFE0ecCK7QNc+ZtJnIqpLRETmHwih?=
 =?iso-8859-2?Q?nN4wC9zMEbkvDbXYQKBBF84c9d99zbyuYUs9VJiBs0dg5rZn49bTsmKTls?=
 =?iso-8859-2?Q?t8jJACSDv/DaCvyekGO8j7RgGqp+Rn7b/Jh6XWT692dtI/4q9AeW4wZe9m?=
 =?iso-8859-2?Q?hPAxht0s+4P1cnBtUbQ=3D?=
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ambarella.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR19MB4024.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e161b2d-7518-4493-f644-08d9c42df835
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 02:59:56.4619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3ccd3c8d-5f7c-4eb4-ae6f-32d8c106402c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uDGrV0C69S8Ri1XmM79l7wu/fM7nDcrfezMl6Kg/kW3T7pqVOocgITDRCuoo7EoFWP2OMdilLrw8mmj3zoEdIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR19MB3909
X-Proofpoint-GUID: v6aGGrZw4PwudfGdi52h8YnsdEPZw_MI
X-Proofpoint-ORIG-GUID: v6aGGrZw4PwudfGdi52h8YnsdEPZw_MI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-21_01,2021-12-20_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 phishscore=0 priorityscore=1501
 malwarescore=0 impostorscore=0 mlxlogscore=660 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112210011
Content-Type: text/plain; charset="iso-8859-2"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is no sense to go further if we have no interrupts.

Signed-off-by: Li Chen <lchen@ambarella.com>
---
 drivers/pci/endpoint/pci-epc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci=
-epc-core.c
index 38621558d3975..3bc9273d0a082 100644
--- a/drivers/pci/endpoint/pci-epc-core.c
+++ b/drivers/pci/endpoint/pci-epc-core.c
@@ -334,7 +334,7 @@ int pci_epc_set_msi(struct pci_epc *epc, u8 func_no, u8=
 vfunc_no, u8 interrupts)
 	u8 encode_int;
=20
 	if (IS_ERR_OR_NULL(epc) || func_no >=3D epc->max_functions ||
-	    interrupts > 32)
+	    interrupts < 1 || interrupts > 32)
 		return -EINVAL;
=20
 	if (vfunc_no > 0 && (!epc->max_vfs || vfunc_no > epc->max_vfs[func_no]))
--=20
2.34.1

**********************************************************************
This email and attachments contain Ambarella Proprietary and/or Confidentia=
l Information and is intended solely for the use of the individual(s) to wh=
om it is addressed. Any unauthorized review, use, disclosure, distribute, c=
opy, or print is prohibited. If you are not an intended recipient, please c=
ontact the sender by reply email and destroy all copies of the original mes=
sage. Thank you.