Date:   Tue, 21 Dec 2021 06:28:42 +0200
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     netdev@vger.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] prestera: add basic router driver support
Message-ID: <YcFX+mDgMZFS+d7L@yorlov.ow.s>
References: <20211217195440.29838-1-yevhen.orlov@plvision.eu>
 <Yb4R55w1mq+NXOwO@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yb4R55w1mq+NXOwO@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?igIgENbSf1ooMX7ZcC52J2qxBN55TFRELckip7tMOOegGp0CcrLwOvtHf4cw?=
 =?us-ascii?Q?qBSGFJcbyFUeXlDvJMbb/dAAEHEuNlgrwdZOBVRclwVxSpm7U265NDMytrCg?=
 =?us-ascii?Q?3QY7Nz27TrK2QCakRb0RDEnvrK9BKDIBThZidLj8EL1iGi3FekbJnpUNEQR7?=
 =?us-ascii?Q?7dIiPRqa73ZHjt0qi/CYGR7igZHRXoUKF/BCvN33qHTiQOEXNd5w5Z8gfGLo?=
 =?us-ascii?Q?FpFTO4u5WeV58OtCZ8hVPVklDCKLdWnnhFi09pZC7ROG9bN6Fcg+2jyjdbMh?=
 =?us-ascii?Q?yKCt+A+agcI0oWbH1WcBZHG99b7iQAO5425MurYl70w3UZtHKdV3uRsypQPf?=
 =?us-ascii?Q?QpIrkOIPKVD4dH1lBpvuVbFwJgW32vp0W58XbVZZIUrt9ffrpTAcc1vtCFcp?=
 =?us-ascii?Q?vYfOYY+T+zweHZYWaAjHxvvNagrpDV0Tm+pUWmrV3zgLmtTbLkbQJm79oYX+?=
 =?us-ascii?Q?bOfoX09h4/nYZPgILnEwlk30LUYolFiN+nOoBNCwUo1djWX2LUgu+TLXMm3+?=
 =?us-ascii?Q?z87XI3sCQ69al1mglUbq/tl9LlcMsv7G37RuDDKBzAaup9KklcHjBGPGpS6w?=
 =?us-ascii?Q?GsZdRrhpKbIqYavY2lskBZDXeIt42RsexcWHmXQiA5Cn4ZrZSevcYQpBu+ra?=
 =?us-ascii?Q?isxRtWYkzLQNkld0SZlMS7V+072BsiubDyNEcAqpv/d9u/gORg4NNbJkT3lI?=
 =?us-ascii?Q?omkHcfLlg2Um2xwFb5aGN/oTAzONJrB90OJ6Ktw8q5f7Dvs7en9Pv174K9k0?=
 =?us-ascii?Q?lMCKcitzBmJRO3L9Mm7PqEx7DXAlsvKfBwy+CVz8zJpIHAJJCSKpqRzFyu13?=
 =?us-ascii?Q?3m/tlmMNVUcwApl4OjM9KO0kDOxdoS6o74ZO3JDM4p3KQSuKvYbPuKfpfBAH?=
 =?us-ascii?Q?o30COOvBhC0YK6l4l269yUD2wrqhi5WHTX4kWF2gSOAik+bRgFwm6Ct0ZAel?=
 =?us-ascii?Q?rp4XbzwCOQ+IyyQaSfei+V+AlziFTVXBbdC8AZBRByR1XLxWnaacNC6jR15m?=
 =?us-ascii?Q?3rKlaVsjyQJdPcRymp1EaTFWjmVw6B86vxPok9CmlPXxKtA1FmYtb4NIv2Vy?=
 =?us-ascii?Q?jDy8VNG3IoEB51SjartNRBXlOAtQWE6fkXm/cI0aK5FZR8ZB+6oT4+386Wla?=
 =?us-ascii?Q?MFwVxlOf5mmVBEIJsCIXkCP3LjGiFTvSv1lDHITUxYScPOz1XE6nq5np43VI?=
 =?us-ascii?Q?rmjdu5QOwW86UOxoL0mfW4nx9v99esfEamkes7TNIo8Bg8BacaRTr2p3KBI2?=
 =?us-ascii?Q?ISOCSxDnEw6Pa4AAJURnXP7gy1bw8eXqeMfa8LRt17JfuJ4Jn/1PuAXVIym5?=
 =?us-ascii?Q?tM+FcVvfoGgoVAb082IGCL1dfae1/Ogmmp+pv2sepz88Ad5GuYCE5pi1eJ7K?=
 =?us-ascii?Q?I/wholsSQtIHmlfZcNklHRikTYd5bkcZTrymM0acRur9WjrI+8lJBC7dwtpe?=
 =?us-ascii?Q?IZCuYwL2T1wXntmxnN4RU18BNT224fDNaN9/jpnj+3kn8ikIPLX9oKLGiiKN?=
 =?us-ascii?Q?dkGtBnoRbZ33kw7IMGf10yH3RlqWgf6O4cgCNdtkXabKqD9iSMb2zXYBZE6c?=
 =?us-ascii?Q?gOfQ/dPC6tiq7dkcAURbY6NnlX22nbL1mPkJdAOSVopTc0t6BIF1R8lpGQHi?=
 =?us-ascii?Q?s+I0o5GRIcCkkWXZktq5vaGh63VtOGJDq5seWwCjmpqAu0kxPf4rej6RL7AW?=
 =?us-ascii?Q?QS7dNg=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: d34c86ce-53c7-4a4e-0c70-08d9c43a601e
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 04:28:45.1864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lga582zcn6c9DsXiM4/JQzX8hGJ4UTnUyqkOokdWJJd0FYdKzHnHEZiS5zyOLnHBkL4KzctzxFWYwDgqCUWIeeP6UvH46t1vrbg/VAcJSFU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0P190MB0642
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 18, 2021 at 05:52:55PM +0100, Andrew Lunn wrote:
> On Fri, Dec 17, 2021 at 09:54:32PM +0200, Yevhen Orlov wrote:
> > Add initial router support for Marvell Prestera driver.
> > Subscribe on inetaddr notifications. TRAP packets, that has to be routed
> > (if packet has router's destination MAC address).
> 
> I must be missing something here. Why do you need to tell it the IP
> address in order to perform software routing? All the switch needs to
> know is the MAC address. Any packets for that MAC address should be
> trapped to the host. The host can then decide what to do with it,
> router, bridge, or consume it itself.

You are right. We don't pass IP address. Subscription is only needed
to enable rif. IP address is not used here.

> 
> > Add features:
> >  - Support ip address adding on port.
> >    e.g.: "ip address add PORT 1.1.1.1/24"
> 
> This should just work already. If it does not, you have something
> wrong in your current support.
> 
> 	Andrew

Yes. For now we has just enabled TRAP's for every port. This is good for
software routing. But in order to implement routes offloading - we need
to control, on which port packets is routed. So, this patchset
prepares infrastructure for future routes offloading implementation.