Date:   Tue, 21 Dec 2021 06:32:05 +0200
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     Stephen Hemminger <stephen@networkplumber.org>
Cc:     netdev@vger.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/6] net: marvell: prestera: Implement initial
 inetaddr notifiers
Message-ID: <YcFYxW2aeTnVVapz@yorlov.ow.s>
References: <20211217195440.29838-1-yevhen.orlov@plvision.eu>
 <20211217195440.29838-7-yevhen.orlov@plvision.eu>
 <20211217130325.305961eb@hermes.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211217130325.305961eb@hermes.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o8hhHwddl+ZyyXcKl3YJv/u7LLQ3XAY1K1EPQZ9BqT+VVXKgxW1wJ8kLp1tF?=
 =?us-ascii?Q?2WghngmYeLEZgyjBp/b71nxqr96cj7D5KtEbuwcs8EfdLTmjBYIxyCVlw1XP?=
 =?us-ascii?Q?KS3bn+xArFnqRSyWQYKUNYqd3r9Q5uNIgt0y53JgmbXFRYnNPFYWWc9ba5lN?=
 =?us-ascii?Q?uL2ia5ku58Prj2oPLj+5wYogC2/Z58JOnM7qxI1KXvqHSktaeFglKreOwhrj?=
 =?us-ascii?Q?I0tNAL3yqsEw8SnM/NpnTTFs4xrzSkya0DxFaExIF8sutpjGqt0QyNYSg0W+?=
 =?us-ascii?Q?jfpsxWlw/+J6+nmE7yaxqkTSler+Wi7TJnRFrmUI2fq1Zkk1GHuefe5q1dDN?=
 =?us-ascii?Q?9cG5xNHueeximQXGdomGYdf2Hnw3GIB2E2Ty7exMWxB17T110BFOojO+4S/D?=
 =?us-ascii?Q?JgihZDzw+ecJbTVs+6W4eLTgbMJbMhnCwbE3JqVs8+lH1sEUOsa+52A6Gp/n?=
 =?us-ascii?Q?VI7G5ymTl4z+dbDMY88HhF1NG4y/Uhj/w99O2FIFsHJuO3fuMJv44S7vk6Xk?=
 =?us-ascii?Q?uT/GmD2sif172KMr9HzVwnNR4u6rQ6kjP4vuRV9nxJld4cKgsF3B6VabuFXQ?=
 =?us-ascii?Q?qCefL+TklUyodpAyuwwEFnCmVJ2q/bFje0+KR6n341l9b/Xssr965yzdJ9/d?=
 =?us-ascii?Q?52l5UlgdvnW7rT8TmywWcOZZ9yCk9BsJM+uXJpJiTQyD03FyCgF6v9JkLIHy?=
 =?us-ascii?Q?jpiKpC6gEX1tMTB4r8IryfG8hmLJRQ4JN2Ha+EwwXdpuhE8O1lyngfiSAIz9?=
 =?us-ascii?Q?w6Gueaqh0AheLNQZZVjWKjQMBkKUUp6eRRmIQC7LxoQzIucFXBnEefJwohdo?=
 =?us-ascii?Q?DLNfSKa3YjXaBzhjayEra9wisWdu+5yIHQqV79+sJpb8bKMISJSrSJY3xQUQ?=
 =?us-ascii?Q?3foB8f+LuvjdqfIL1jDJsqgaOwLz7bjTsb/eLO189dxh1N9S1bKkaLknd8Xz?=
 =?us-ascii?Q?Q53D0pGuQTe2zCpj2kkQ9I7JxOiAJE/63s4QUf5q2B9BG7Hzxm0gFBjHNwKv?=
 =?us-ascii?Q?cH5UIYi4HOy7yTuj9K74KPYQOAB6mO0Ari4gHX9r8mueqsVFYQ/KX9Y6Wgo8?=
 =?us-ascii?Q?wUhrvmCNsyy1GLG3V41cFRLRPvdHw+nysp2A1jswm7gS5AQNc6EclXQ/L9WO?=
 =?us-ascii?Q?XCqStjauN8D28kOSIfFqDWq4iZFuvU1HhSSKdDXRyRBEHUKhwJnzRORBhcHx?=
 =?us-ascii?Q?0qm5Xv4BTDpo/xbiNFLfOhT6sUIaiPUTStpHsrlw/GbI1liQ7LRlzJQHjAS8?=
 =?us-ascii?Q?B1IUoOzAnfDr3IpuISggEL1zsTXoOVIcxGjJDrdRyJwhXFkeEaqA0oppiH6L?=
 =?us-ascii?Q?3mBAUs+45WiQ+PuZQOJYk3V8SZNl9c9RvdEx1yXst525ne4yhNLYV4Y+n3OI?=
 =?us-ascii?Q?H88RVWYl1uXWH/U7x4xgZ0eOaRVBFOrGmXSP9k+kWWXN0GoIWDCfkhxnSS8D?=
 =?us-ascii?Q?GniVf89FEcluYa1o6tWudlmmdAsN6Dmx9ZV6aXAAD/LvjSY1iadmRuZJygkQ?=
 =?us-ascii?Q?6c36m/6cvL85Jo7MrpgMPsg6ve17xnYInP4LRdni/ygKBeNXcLRb0S7xFUCo?=
 =?us-ascii?Q?KueBAcYhqdKJ0PGYIYghb3ZjQ1CKWphkttNX4BzIBOql4a0vaNUOSo2b6cuE?=
 =?us-ascii?Q?DSlVWdixOm/4nIOUjefdXTJDW4aM8sc7Tj3cV8X8q6o2TZjqKUpffGvUZY3h?=
 =?us-ascii?Q?Nhm0UY31zA5m1FouHxbM/2qJ39w=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cca0340-2776-42a9-072f-08d9c43ad934
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 04:32:08.2411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1hqQHOi94FnyVUVhe1DV2m8geWdn+ZKTe+xOSLmFMlj7xwH1ICjmTcWLIAiXsz36L+CRGdQPRIQPpmpn+LYrt8Xn7pRWnRlTZ6LiZJ0lRL0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P190MB1156
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 17, 2021 at 01:03:25PM -0800, Stephen Hemminger wrote:
> How are these device references cleaned up on module removal?

Removing the module removes the port, and clears all addresses:

    __prestera_inetaddr_event.part.0+0x190/0x3b0 [prestera]
    __prestera_inetaddr_cb+0x94/0xb0 [prestera]
    blocking_notifier_call_chain+0x98/0xd0
    __inet_del_ifa+0x2e4/0x4e0
    inetdev_event+0x260/0xa20
    raw_notifier_call_chain+0x74/0xa0
    call_netdevice_notifiers_info+0x68/0xc0
    unregister_netdevice_many+0x4f4/0xa20
    unregister_netdevice_queue+0x13c/0x180
    unregister_netdev+0x24/0x40
    prestera_port_destroy+0x44/0xe0 [prestera]
    prestera_device_unregister+0x6c/0x110 [prestera]
    prestera_pci_remove+0x28/0x80 [prestera_pci]
    pci_device_remove+0x68/0x130
    __device_release_driver+0x228/0x320
    driver_detach+0x12c/0x1c0
    bus_remove_driver+0x88/0x120
    driver_unregister+0x44/0x80
    pci_unregister_driver+0x2c/0xe0
    prestera_pci_driver_exit+0x18/0x30 [prestera_pci]
    __arm64_sys_delete_module+0x20c/0x310
    invoke_syscall+0x60/0x190