Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31207C433FE for ; Tue, 21 Dec 2021 06:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234433AbhLUG7J (ORCPT ); Tue, 21 Dec 2021 01:59:09 -0500 Received: from mga17.intel.com ([192.55.52.151]:57715 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233417AbhLUG7I (ORCPT ); Tue, 21 Dec 2021 01:59:08 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10204"; a="221015349" X-IronPort-AV: E=Sophos;i="5.88,222,1635231600"; d="scan'208";a="221015349" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 22:59:08 -0800 X-IronPort-AV: E=Sophos;i="5.88,222,1635231600"; d="scan'208";a="521128571" Received: from xingzhen-mobl.ccr.corp.intel.com (HELO [10.238.4.155]) ([10.238.4.155]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 22:59:05 -0800 Message-ID: Date: Tue, 21 Dec 2021 14:59:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] perf pmu: Fix event list for uncore PMUs Content-Language: en-US To: "Liang, Kan" , John Garry , Arnaldo Carvalho de Melo Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, irogers@google.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <1639670017-74918-1-git-send-email-john.garry@huawei.com> From: Xing Zhengjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/2021 12:34 AM, Liang, Kan wrote: > > > On 12/20/2021 3:38 AM, John Garry wrote: >> On 18/12/2021 01:47, Arnaldo Carvalho de Melo wrote: >>>> Commit 0e0ae8742207 ("perf list: Display hybrid PMU events with cpu >>>> type") >>>> changed the list for uncore PMUs, such that duplicate aliases are now >>>> listed per PMU (which they should not be), like: >>>> >>>> ./perf list >>>> ... >>>> unc_cbo_cache_lookup.any_es >>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found >>>> line in E or S-state] >>>> unc_cbo_cache_lookup.any_es >>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found >>>> line in E or S-state] >>>> unc_cbo_cache_lookup.any_i >>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found >>>> line in I-state] >>>> unc_cbo_cache_lookup.any_i >>>> [Unit: uncore_cbox L3 Lookup any request that access cache and found >>>> line in I-state] >>>> ... >>>> >>>> Notice how the events are listed twice. >>> Hi Jin, >>> >>>     Can I have your acked-by/tested-by? >> >> Hi Arnaldo, >> >> I assume that address is bouncing for you also. >> > > Yes, Jin Yao has left Intel. > >> So if anyone else has one of these hybrid PMU x86 systems then it >> would be appreciated to check this change. >> > > + Zhengjun > > Zhengjun, > > Could you please help to verify the change? > > Thanks, > Kan Tested this patch on one hybrid PMU x86 system, it works OK. Tested-by: Zhengjun Xing -- Zhengjun Xing