Date:   Tue, 21 Dec 2021 12:42:19 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     20210106125322.61840-14-manivannan.sadhasivam@linaro.org
Cc:     Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        agross@kernel.org, bjorn.andersson@linaro.org
Subject: Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom:
 sdx55: Add spmi node
Message-ID: <20211221071219.GD26872@thinkpad>
References: <HTKF4R.5S1PY4MCM4QS@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <HTKF4R.5S1PY4MCM4QS@ixit.cz>
Precedence: bulk

On Mon, Dec 20, 2021 at 09:27:17PM +0100, David Heidelberg wrote:
> Hello Manivannan,
> 
> I'd like to ask, if you had any particular reason to name node `qcom,spmi@`
> instead of basic `spmi@`.
> 

"spmi" node label was not documented by devicetree spec at that time. So I was
using "qcom,spmi" but it was not correct either.

I've submitted a PR now to devicetree-spec repo [1] for listing it as the
generic node name. So once it got accepted, we can use "spmi@" for the node
name.

Thanks,
Mani

[1] https://github.com/devicetree-org/devicetree-specification/pull/50

> I'm currently converting binding for
> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
> 
> Ideas, inputs?
> 
> Thank you
> David
> 
>