Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA139C433EF for ; Tue, 21 Dec 2021 08:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235720AbhLUIlf (ORCPT ); Tue, 21 Dec 2021 03:41:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235711AbhLUIle (ORCPT ); Tue, 21 Dec 2021 03:41:34 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDEE3C061574; Tue, 21 Dec 2021 00:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1SfuWtyBT/lCOeUjHpOa8oNjQ7IYPylpMxyFG1nXMrQ=; b=UO/t1vtyfCs/03PyiOpu8/Jt28 8yISYgBUk47c8mXqrG4qYbjL5hAseZWZypz86F42rcXgxhiIGSKAoUsXnHc2wlMNQnYSlPhXvylG4 eb1x+8vcDP+1jqnqFCa40Tv/7KpmvLEyW+o0miLF3XhMjt8PbB8vC5gVYHPjghjf6aS8MpFwfArCM I1omI8tzS497dL4Oo+VWRXnxYysvRAx/8W2B9lmiC6JJyn9B21TN0hyJGLuV4KDCwqCPRai+06t3B tsxNDzngO0OEwEZNXvNddGlo63h5U76bPHODnDJF/rv3d7QF/LHhj3G/zVq4spBK/TicWybqsazm8 4f3lfJyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzai9-005xhw-Km; Tue, 21 Dec 2021 08:41:29 +0000 Date: Tue, 21 Dec 2021 00:41:29 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/18] MM: perform async writes to SWP_FS_OPS swap-space Message-ID: References: <163969801519.20885.3977673503103544412.stgit@noble.brown> <163969850292.20885.16191050558510542930.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163969850292.20885.16191050558510542930.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 17, 2021 at 10:48:22AM +1100, NeilBrown wrote: > Writes to SWP_FS_OPS swapspace is currently synchronous. To make it > async we need to allocate the kiocb struct which may block, but won't > block as long as waiting for the write to complete would block. Against a little helper for the SWP_FS_OPS case of __swap_writepage would be nice. But otherwise this looks good to me.