Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3FAC433FE for ; Tue, 21 Dec 2021 09:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236018AbhLUJEx (ORCPT ); Tue, 21 Dec 2021 04:04:53 -0500 Received: from verein.lst.de ([213.95.11.211]:46026 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233775AbhLUJEu (ORCPT ); Tue, 21 Dec 2021 04:04:50 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 492B168BEB; Tue, 21 Dec 2021 10:04:42 +0100 (CET) Date: Tue, 21 Dec 2021 10:04:41 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni Subject: Re: [PATCH v4 16/23] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() Message-ID: <20211221090441.GC7949@lst.de> References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-17-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117215410.3695-17-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All these new helpers should be _GPL exports, keeping the existing ones (which should never have been non-GPL exports as tiny wrappers around GUP-fast) as out of line wrappers.