Date:   Tue, 21 Dec 2021 10:10:36 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <YcGU6pQqfEPBqjrO@google.com>
References: <20211220144654.926112-1-pgwipeout@gmail.com> <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45> <YcGU6pQqfEPBqjrO@google.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Reply-to: frank-w@public-files.de
To:     Lee Jones <lee.jones@linaro.org>
CC:     Peter Geis <pgwipeout@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-kernel@vger.kernel.org
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <4963E4A2-63B4-48A1-BDDD-5F9D07D71598@public-files.de>
Precedence: bulk

Am 21=2E Dezember 2021 09:48:43 MEZ schrieb Lee Jones <lee=2Ejones@linaro=
=2Eorg>:
>On Mon, 20 Dec 2021, Frank Wunderlich wrote:
>
>> Hi
>>=20
>> > Gesendet: Montag, 20=2E Dezember 2021 um 15:46 Uhr
>> > Von: "Peter Geis" <pgwipeout@gmail=2Ecom>
>> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client
>*client)
>> >  	if (pm_power_off =3D=3D rk808_pm_power_off)
>> >  		pm_power_off =3D NULL;
>> >
>> > +	if (of_property_read_bool(np,
>"rockchip,system-power-controller"))
>> > +		unregister_restart_handler(&rk808_restart_handler);
>> > +
>> >  	return 0;
>> >  }
>>=20
>> this change misses a declaration
>>=20
>> struct device_node *np =3D client->dev=2Eof_node;
>
>How did this compile when you tested it?

Here i have squashed the change in:

https://github=2Ecom/frank-w/BPI-R2-4=2E14/commit/06430ffcb6d58d33014fb940=
256de77807ed620f

With the change i can compile it=2E=2E=2E

But in v4 (patch is tagged as v3 too) the of_property_read_bool was droppe=
d completely=2E
regards Frank