MIME-Version: 1.0
References: <20211221092830.680839-1-yinxiujiang@kylinos.cn>
In-Reply-To: <20211221092830.680839-1-yinxiujiang@kylinos.cn>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 21 Dec 2021 07:20:53 -0400
Message-ID: <CAL_JsqLtQanbiC4egB8d5quQRZNq0V6q2s+=qhBeypBqLH-pgA@mail.gmail.com>
Subject: Re: [PATCH] of: unittest: Fix out of bounds array access when id < 0
To:     Yin Xiujiang <yinxiujiang@kylinos.cn>
Cc:     frowand.list@gmail.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 21, 2021 at 5:34 AM Yin Xiujiang <yinxiujiang@kylinos.cn> wrote:
>
> In of_unittest_untrack_overlay if id is less than 0 then
> overlay_id_bits will be out of bounds. And it is also mentioned
> in bugzilla as a bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=214867
>
> Fix this bug by tiggering WARN_ON()

If id shouldn't be less than 0, can we make it unsigned instead as
discussed here[1].

Rob

[1] https://lore.kernel.org/all/c474a371-b524-1da8-4a67-e72cf8f2b0f7@gmail.com/