MIME-Version: 1.0
In-Reply-To: <20211221090714.122543-2-yang.lee@linux.alibaba.com>
References: <20211221090714.122543-1-yang.lee@linux.alibaba.com> <20211221090714.122543-2-yang.lee@linux.alibaba.com>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Tue, 21 Dec 2021 20:39:57 +0900
Message-ID: <CAKYAXd_5M6Wajx2Zqv9vaAs1oRLO7YCv4iKxzoqpZ4UqVc+oPA@mail.gmail.com>
Subject: Re: [PATCH -next 2/4] ksmbd: Fix smb2_set_info_file() kernel-doc comment
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     senozhatsky@chromium.org, sfrench@samba.org, hyc.lee@gmail.com,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2021-12-21 18:07 GMT+09:00, Yang Li <yang.lee@linux.alibaba.com>:
> Fix argument list that the kdoc format and script verified in
> smb2_set_info_file().
>
> The warnings were found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
> fs/ksmbd/smb2pdu.c:5862: warning: Function parameter or member 'req' not
> described in 'smb2_set_info_file'
> fs/ksmbd/smb2pdu.c:5862: warning: Excess function parameter 'info_class'
> description in 'smb2_set_info_file'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 9496e268e3af ("ksmbd: add request buffer validation in
> smb2_set_info")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  fs/ksmbd/smb2pdu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index ee2bcd02d0d7..2d55a186b825 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -5850,7 +5850,7 @@ static int set_file_mode_info(struct ksmbd_file *fp,
>   * smb2_set_info_file() - handler for smb2 set info command
>   * @work:	smb work containing set info command buffer
>   * @fp:		ksmbd_file pointer
> - * @info_class:	smb2 set info class
> + * @req:        request buffer validation
I will directly update it to "request buffer pointer".

About your 4 patches, Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks!
>   * @share:	ksmbd_share_config pointer
>   *
>   * Return:	0 on success, otherwise error
> --
> 2.20.1.7.g153144c
>
>