From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [RFC PATCH v12 00/17] dlb: introduce DLB device driver
Thread-Topic: [RFC PATCH v12 00/17] dlb: introduce DLB device driver
Thread-Index: AQHX9jcJdm85rPhvxUq3c7I9WRTitKw8hvqAgABjytA=
Date:   Tue, 21 Dec 2021 14:03:38 +0000
Message-ID: <CO1PR11MB51700037C8A23B19C0DCF5CAD97C9@CO1PR11MB5170.namprd11.prod.outlook.com>
References: <20211221065047.290182-1-mike.ximing.chen@intel.com>
 <YcF9rRTVzrbCyOtq@kroah.com>
In-Reply-To: <YcF9rRTVzrbCyOtq@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s5WRZCgeYRSyYd1tdsuk3Q6FZx5iu06KJiefgbREmMJtOS2/kCYAz8oeqwZ9?=
 =?us-ascii?Q?J+dA2bQurl25arNQcOK7issF5jTD+Zwi3/DKNzMh8M5zRY2qqE2tE6BM4+VT?=
 =?us-ascii?Q?s2lYF6DWoc33EUCqVjxYX/5eynyQ+vPLYYGMT1FhPIbkbmINLNmY6yOLou9i?=
 =?us-ascii?Q?o1GfhkAUx68OLjmvpNMflJ9P8pXrowmO6czajyQA4shLsTZaK5hcpFoT2MNf?=
 =?us-ascii?Q?FQpvSyMlSGyqKYRZWmDOSUFGHUJKVTi5ci+jBya1xiy4PTEncMzk9ZAdOEM9?=
 =?us-ascii?Q?UAKQrMjXtM4XtveuktDeKGmdOwLAIrwNgHSrIR6ZvtWSTIcsmm6c+JVrUmDV?=
 =?us-ascii?Q?9DHOSOhtsjNoEZenouq6sRwUv5aEx5l5tPaJXPqiCSqqTpu7KmhdID3eTXFg?=
 =?us-ascii?Q?cg8LGUN2SzaDubXBo81X85FvajV6E99a83W1Y7dE5Uclu1gaRXZulpVlscff?=
 =?us-ascii?Q?ZFPH7ETuQssu8jqokmlYUJq1qIxjsC45r/R00MXQ5hXvFWxEr4gydZklta6E?=
 =?us-ascii?Q?URe111R5RTn+du3Kdje02qg6ZNtyKiRfG/554juPcvPasl5pk7zFttW2cJUf?=
 =?us-ascii?Q?wUEGhk/k+bKThsY7+tbaPOuYF+fmWAHzCEfzojVjbzirOIqL0wzPvbhQAVQT?=
 =?us-ascii?Q?xRnFU1HQy8oRtySXNpXkUhjhpFLfQeVva7kw2wjX2+8YIXJJ90rx6JGy5ee3?=
 =?us-ascii?Q?rAi4bzuVz2CYftD+bsHZ8xzySMrZord0IykMUPtWi0d3DN+mxPjCT6z2URUD?=
 =?us-ascii?Q?IUeHwpx1e2Ga8rwSWmmw2Glx+RtKIu5O0scGTJZVfJZ6B8SwplbPg0VwX3Zj?=
 =?us-ascii?Q?QEbKkqN6IigDXcND6WZCSwNUCmXyMiGD5YEeVSnI+pYmFGoh4l3SCFuq2i4i?=
 =?us-ascii?Q?zixQtIY0Ew0vbly1sQvIywXedohRFVa4GW3yg83lCJkQn2hFCxAIQhNLqkAw?=
 =?us-ascii?Q?P0L+tbxPFQMNvRns8HAr+0aJXP5t7GuYC+oe5ei3LPatcqNLWzzcmCAF7Jk8?=
 =?us-ascii?Q?WL7m7+el31dSS0PLY8FD0vkA77cZxmjCqw5TiC+vwfO+0mZnKSSraGdXKbyw?=
 =?us-ascii?Q?lw2Di04SV1RmxbZ7Eu37/cqMjfR6gHn0OFvFzqu/fFOSX0THy8Zw/z/jF3oq?=
 =?us-ascii?Q?MMlphqpFQvpoSOFkXlYy5vxNef4wKu3V3VZpgioo2dq96XXLrp0L8hRf1OP8?=
 =?us-ascii?Q?1dcW0x40p+0OsBNG5xcEnGeNCBtT3a8f4BhrEtONzuh7aeirYPtEJEyuY0yA?=
 =?us-ascii?Q?BGvIgLiUfCmzjDyKlGMrQ7s4rnK4aFHj6M+TQzHxFyvp6ApUVFWzOS+xYbhC?=
 =?us-ascii?Q?iQVQXLCZFjlNCoku7dudy1iFqwDrEOSpCjJ3jU6Z8Wc+jOeVL2ae2tbjICu1?=
 =?us-ascii?Q?TjH2jj+fT7PrXqyaBkwslpHsTCwepQMEZLpTJCReE+L2crFod8lAIYx/LGoy?=
 =?us-ascii?Q?Xy2CGRkRZPLDnv/NBftvO8QRi3fNG45G0YoOYTEgY7oIYWeYdupn/MMEq9vs?=
 =?us-ascii?Q?R9+BLVPUT6T3gfTYSmFE45kbOPMSeZyfRhubSrSd/aUp0mONIAunP0TwDPLc?=
 =?us-ascii?Q?Qt0w1OysqLkCra595XeSGLJdE08kjqP0zhJk7T+0bJ2V3cI984oYKbxlBzhI?=
 =?us-ascii?Q?qDFlHgP9OqZIcTUPnBppE1DT8y2lfwcHoeqEUmwxXi3fcRI4XB4Je+Tt72Ld?=
 =?us-ascii?Q?75tgvA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5170.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8e331fe-b4f3-4dc7-01f2-08d9c48aafe8
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 14:03:38.3910
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IZtkM9DaAzptvLhnTp6yq/gh9qB13oOwxYn7sG/6WkgDVP7RGsX7CX9k6+lbvaslw4qASqhBsThn0bKRlycA33h/aPH0pbHl2kfE6pMmJLs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5890
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, December 21, 2021 2:10 AM
> To: Chen, Mike Ximing <mike.ximing.chen@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Williams, Dan J <dan.j.w=
illiams@intel.com>; pierre-
> louis.bossart@linux.intel.com; netdev@vger.kernel.org; davem@davemloft.ne=
t; kuba@kernel.org
> Subject: Re: [RFC PATCH v12 00/17] dlb: introduce DLB device driver
>=20
> On Tue, Dec 21, 2021 at 12:50:30AM -0600, Mike Ximing Chen wrote:
> > v12:
>=20
> <snip>
>=20
> How is a "RFC" series on version 12?  "RFC" means "I do not think this sh=
ould be merged, please give me
> some comments on how this is all structured" which I think is not the cas=
e here.

Hi Greg,

"RFC" here means exactly what you referred to. As you know we have made man=
y changes since your
last review of the patch set (which was v10).  At this point we are not sur=
e if we are on the right track in
terms of some configfs implementation, and would like some comments from th=
e community. I stated
this in the cover letter before the change log: " This submission is still =
a work in progress.... , a couple of
issues that we would like to get help and suggestions from reviewers and co=
mmunity". I presented two
issues/questions we are facing, and would like to get comments.=20

The code on the other hand are tested and validated on our hardware platfor=
ms. I kept the version number
in series (using v12, instead v1) so that reviewers can track the old submi=
ssions and have a better
understanding of the patch set's history.

>=20
> > - The following coding style changes suggested by Dan will be implement=
ed
> >   in the next revision
> > -- Replace DLB_CSR_RD() and DLB_CSR_WR() with direct ioread32() and
> >    iowrite32() call.
> > -- Remove bitmap wrappers and use linux bitmap functions directly.
> > -- Use trace_event in configfs attribute file update.
>=20
> Why submit a patch series that you know will be changed?  Just do the wor=
k, don't ask anyone to review
> stuff you know is incorrect, that just wastes our time and ensures that w=
e never want to review it again.
>
Since this is a RFC, and is not for merging or a full review, we though it =
was OK to log the pending coding
style changes. The patch set was submitted and reviewed by the community be=
fore, and there was no
complains on using macros like DLB_CSR_RD(), etc, but we think we can repla=
ce them for better
readability of the code.

Thanks
Mike=20
=20