MIME-Version: 1.0
References: <20211220211854.89452-1-nbd@nbd.name> <20211220211854.89452-8-nbd@nbd.name>
In-Reply-To: <20211220211854.89452-8-nbd@nbd.name>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 21 Dec 2021 15:06:23 +0100
Message-ID: <CAK8P3a3Qy8FJpACTqt85Enm72aJ=vzUfiEMZ4=dRqFmunyOm1Q@mail.gmail.com>
Subject: Re: [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        John Crispin <john@phrozen.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 20, 2021 at 10:18 PM Felix Fietkau <nbd@nbd.name> wrote:
>
> This driver only registers fixed rate clocks, since the clocks are fully
> initialized by the boot loader and should not be changed later, according
> to Airoha.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

I don't have any particular comments on the driver itself. I'm happy
to merge it through
the soc tree for the initial support of the clk maintainers are ok
with it and have reviewed
the actual code.

>  drivers/clk/Kconfig      |   9 +
>  drivers/clk/Makefile     |   1 +
>  drivers/clk/clk-en7523.c | 350 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 360 insertions(+)
>  create mode 100644 drivers/clk/clk-en7523.c

I think this should go into drivers/clk/mediatek, as it probably shares
some of the logic with the mt762x drivers in there. I'd suggest adding the
maintainers for those drivers to Cc for additional review.

       Arnd