Message-ID: <3b1b7881bbecc25a2d70f54743f1f6a9decbaa45.camel@linux.ibm.com>
Subject: Re: [GIT PULL 1/2] asm-generic: rework PCI I/O space access
From:   Niklas Schnelle <schnelle@linux.ibm.com>
To:     John Garry <john.garry@huawei.com>, Arnd Bergmann <arnd@kernel.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Tue, 21 Dec 2021 17:57:06 +0100
In-Reply-To: <3d543c90-383f-647a-5cd4-f7fd4e7246ad@huawei.com>
References: <CAK8P3a2oZ-+qd3Nhpy9VVXCJB3DU5N-y-ta2JpP0t6NHh=GVXw@mail.gmail.com>
         <a74dfb1f-befd-92ce-4c30-233cb08e04d3@huawei.com>
         <CAK8P3a3B4FCaPPHhzBdpkv0fsjE0jREwGFCdPeHEDHxxRBEjng@mail.gmail.com>
         <5e8dfbd2-a6c0-6d02-53e9-1f29aebcc44e@huawei.com>
         <CAK8P3a08Zcyx0J4_LGAfU_AtUyEK+XtQJxYBQ52VXfWu8-o8_w@mail.gmail.com>
         <dd2d49ef-3154-3c87-67b9-c134567ba947@huawei.com>
         <CAK8P3a3KTaa-AwCOjhaASMx63B3DUBZCZe6RKWk-=Qu7xr_ijQ@mail.gmail.com>
         <47744c7bce7b7bb37edee7f249d61dc57ac1fbc5.camel@linux.ibm.com>
         <CAK8P3a2eZ25PLSqEf_wmGs912WK8xRMuQHik2yAKj-WRQnDuRg@mail.gmail.com>
         <849d70bddde1cfcb3ab1163970a148ff447ee94b.camel@linux.ibm.com>
         <53746e42-23a2-049d-9b38-dcfbaaae728f@huawei.com>
         <CAK8P3a0dnXX7Cx_kJ_yLAoQFCxoM488Ze-L+5v1m0YeyjF4zqw@mail.gmail.com>
         <cd9310ab-6012-a410-2bfc-a2f8dd8d62f9@huawei.com>
         <CAK8P3a23jsT-=v8QDxSZYcj=ujhtBFXjACNLKxQybaThiBsFig@mail.gmail.com>
         <d45ee18a-1faa-9c56-071d-18f5737d225c@huawei.com>
         <11e180449d82e5276586cdaab5e70a1c1b3adb42.camel@linux.ibm.com>
         <3d543c90-383f-647a-5cd4-f7fd4e7246ad@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

On Tue, 2021-12-21 at 16:48 +0000, John Garry wrote:
> On 20/12/2021 09:27, Niklas Schnelle wrote:
> > >   > My feeling is that in this case we want some other dependency, e.g. a
> > >   > new CONFIG_LPC. It should actually be possible to use this driver on
> > >   > any machine with an LPC bus, which would by definition be the primary
> > >   > I/O space, so it should be possible to load it on Arm64.
> > > 
> > > You did suggest HARDCODED_IOPORT earlier in this thread, and the
> > > definition/premise there seemed sensible to me.
> > > 
> > > Anyway it seems practical to make all these changes in a single series,
> > > so need a way forward as Niklas has no such changes for this additional
> > > kconfig option.
> > > 
> > > As a start, may I suggest we at least have Niklas' patch committed to a
> > > dev branch based on -next or latest mainline release for further analysis?
> > > 
> > > Thanks,
> > > John
> > > 
> > > 
> > My plan would be to split the patch up into more manageable pieces as
> > suggested by Arnd plus of course fixes like the missing ARM select. As
> > Arnd suggested I'll split the HAS_IOPORT additions into the initial
> > introduction plus arch selects and then the HAS_IOPORT dependencies per
> > subsytem. I think these per subsystem dependency patches then would be
> > a great place to find drivers which should have a different dependency
> > be it on LPC or a newly introduced HARDCODED_IOPORT. The thing is we
> > can find and check HAS_IOPORT dependencies easily but it's hard to find
> > HARDCODED_IOPORT so I think the lattter should be a refinement of the
> > former. It can of course still go in as a single series. I'll
> > definitely make the next iteration available as a git branch.
> 
> I'll do an audit for what would require HARDCODED_IOPORT to understand 
> the scope while you can continue the work on your current path.
> 
> Thanks,
> john
> 

Sounds good, I'm open to adding such a config option given a clear
enough picture of what drivers it would affect. Meanwhile I've made
some progress splitting things up. I still need to do a bit more
testing and refining of comments before sending an RFC but if you're
curious you can check out the 'has_ioport' branch on my GitHub here:

https://github.com/niklas88/linux.git  (still figuring out if/how I can
get a proper git.kernel.org branch/repository).

Thanks,
Niklas