Date:   Tue, 21 Dec 2021 17:43:26 +0000
From:   David Brazdil <dbrazdil@google.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Will Deacon <will@kernel.org>,
        Andrew Scull <ascull@google.com>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: firmware: Add Open Profile for DICE
Message-ID: <YcISPrm/R8QIqkMb@google.com>
References: <20211213195833.772892-1-dbrazdil@google.com>
 <20211213195833.772892-2-dbrazdil@google.com>
 <YbpPYG4rzPmJmwA6@robh.at.kernel.org>
 <YbpZTSpmnieCNZ9a@google.com>
 <CAL_JsqJRpNr7McM9OJcPs095ZfAqGJfN7FhGhy7i6pN+tx1MGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_JsqJRpNr7McM9OJcPs095ZfAqGJfN7FhGhy7i6pN+tx1MGg@mail.gmail.com>
Precedence: bulk

On Thu, Dec 16, 2021 at 09:21:00AM -0600, Rob Herring wrote:
> On Wed, Dec 15, 2021 at 3:08 PM David Brazdil <dbrazdil@google.com> wrote:
> >
> > Hi Rob,
> >
> > > > +        dice_reserved: dice@12340000 {
> > > > +            reg = <0x00 0x12340000 0x2000>;
> > > > +            no-map;
> > > > +        };
> > > > +    };
> > > > +
> > > > +    dice {
> > > > +        compatible = "google,open-dice";
> > > > +        memory-region = <&dice_reserved>;
> > >
> > > There's no need for this indirection. Just add the compatible to the
> > > dice@12340000 node. You can bind drivers to /reserved-memory nodes.
> >
> > I have not found a way to make that work for kernel modules. Built-in
> > drivers can bind with RESERVEDMEM_OF_DECLARE, which puts an entry in
> > __reservedmem_of_table and __reserved_mem_init_node() iterates find it
> > there. A good case study might be CONFIG_TEGRA210_EMC, where the driver
> > itself can be a module but the rmem parsing is always built-in under
> > CONFIG_TEGRA210_EMC_TABLE. I don't think that's worth the trouble with
> > this driver.
> 
> I forgot you have to add the compatible to reserved_mem_matches in
> drivers/of/platform.c.

Oh nice! Exactly what I was looking for, thanks. I'll respin shortly.

David