Date:   Tue, 21 Dec 2021 17:57:15 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     matthias.bgg@gmail.com, lgirdwood@gmail.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isoc: mediatek: Check for error clk pointer
Message-ID: <YcIVe+dDoE4SWa3D@sirena.org.uk>
References: <20211217173005.698876-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y1QX5gkzmV5X6OYo"
Content-Disposition: inline
In-Reply-To: <20211217173005.698876-1-jiasheng@iscas.ac.cn>
Precedence: bulk


--y1QX5gkzmV5X6OYo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Dec 18, 2021 at 01:30:05AM +0800, Jiasheng Jiang wrote:

> +	for (i = CLK_NONE + 1; i < CLK_MAX; i++) {
>  		clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> +		if (IS_ERR(clk[i]))
> +			return PTR_ERR(clk[i]);

This now pays attention to the error code here which is good but...

> -	init_clks(pdev, clk);
> +	ret = init_clks(pdev, clk);
> +	if (ret)
> +		return ERR_PTR(-ENOMEM);

...then discards it here with a random most likely inappropriate error
code.

--y1QX5gkzmV5X6OYo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHCFXoACgkQJNaLcl1U
h9Agfgf/f7m/N2DMVZ5PNdYe9h34gphjGr4sR1SnO0LB7atpG9EZ3nAUrR8Dq8HA
v9qoZ9vqPvdaJvzkAQ6Uyk0xeL2MZzalzBicaPDk0ZPMZyMtpGNOBfQ7Hg/eebw0
FgcFdAt7eBcIflPVHE7HxP2Qfma/Yf73nGyF0PClWPeJBUv+D/+IUs2FEmhuOfKT
jK1pw4xc/u8zUYQGR1J8NY3h9e9rLgW/sTwlvDa+o1O+qzZqHdMFDyZd6YUsidQD
/jbPQsA6KMyu0EcUs5r9+JqSJMVhKI1VqfTYxcGfzxKNPs2jyOeBYBbBCqoiWozL
6XZrX1QiHVCptfxh5JkNz2c0Jfppag==
=uxBx
-----END PGP SIGNATURE-----

--y1QX5gkzmV5X6OYo--