Message-ID: <45BA6D8E.1040705@tls.msk.ru>
Date: Sat, 27 Jan 2007 00:07:26 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
Organization: Telecom Service, JSC
User-Agent: Icedove 1.5.0.8 (X11/20061128)
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
Subject: Can a kobject have both bus- and class-specific uevent handlers?
OpenPGP: id=4F9CF57E
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 28

Looking at drivers/base/core.c:dev_uevent() I wonder whenever
a device can have both bus-specific uevent function AND
class-specific one.  If yes, the code in that routine is umm..
wrong.  Because in this case, bus-specific attributes will
be owerwritten by class-specific ones.

I mean this code (debugging omitted for simplicity):

    if (dev->bus && dev->bus->uevent) {
            /* have the bus specific function add its stuff */
            retval = dev->bus->uevent(dev, envp, num_envp, buffer, buffer_size);
    }

    if (dev->class && dev->class->dev_uevent) {
            /* have the class specific function add its stuff */
            retval = dev->class->dev_uevent(dev, envp, num_envp, buffer, buffer_size);
    }

    return retval;

Thanks.

/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/