Message-ID: <5f104044649ec60ba93648e68c3df2183e032072.camel@sipsolutions.net>
Subject: Re: [PATCH] um: virtio_uml: allow probing from devicetree
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        Jeff Dike <jdike@addtoit.com>,
        Richard Weinberger <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     kernel@axis.com, devicetree@vger.kernel.org,
        linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 21 Dec 2021 21:48:26 +0100
In-Reply-To: <20211221090447.1567-1-vincent.whitchurch@axis.com>
References: <20211221090447.1567-1-vincent.whitchurch@axis.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2 (3.42.2-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-12-21 at 10:04 +0100, Vincent Whitchurch wrote:
> Allow the virtio_uml device to be probed from the devicetree so that
> sub-devices can be specified using the standard virtio bindings, for
> example:
> 
>   virtio@1 {
>     compatible = "virtio,uml";
>     socket-path = "i2c.sock";
>     virtio-device-id = <0x22>;
> 

Given this, maybe it should modify
Documentation/devicetree/bindings/virtio/virtio-device.yaml? Or actually
add a new Documentation/devicetree/bindings/virtio/uml.yaml I guess?

+Rob, because I'm not really into any of this.

Also, I'm not even sure we should/need to document the DT bits that are
basically only used for testing in the first place?

Code looks good to me.

johannes