From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Joe Perches <joe@perches.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
Thread-Topic: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
Thread-Index: AQHX9jcKOP1y1O92CEC3pIeygh1pI6w8hGUAgAER9fA=
Date:   Tue, 21 Dec 2021 23:22:21 +0000
Message-ID: <SJ0PR11MB51812066CF2DD4458231F280D97C9@SJ0PR11MB5181.namprd11.prod.outlook.com>
References: <20211221065047.290182-1-mike.ximing.chen@intel.com>
         <20211221065047.290182-2-mike.ximing.chen@intel.com>
 <60d35206a67a98a0d0fd58d6f47c8dd1312e168e.camel@perches.com>
In-Reply-To: <60d35206a67a98a0d0fd58d6f47c8dd1312e168e.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8CS+3Zx1kiDK6150yXGU+dTqfTn6y2CRRpwpbBXlfN4dbml2vru/lvVmJCn+?=
 =?us-ascii?Q?pooXOxvTKdihYOXrPDKxFcuCtQNEsZvA+EDQjwWeuCXf0cJRpGQYwaf4vLRg?=
 =?us-ascii?Q?0QSbV9+bGPLu006G1YV8qzJpDgHMp0ExoUwd3SK69/qviwBXQJLudUyfu+Lr?=
 =?us-ascii?Q?5dJi30dbrwwSZgRBhZ2A96s8XRBAp3L6bGaiywcpGghbvpekML9gYnLkgxMk?=
 =?us-ascii?Q?yo5ZU0KeKeuofTF7e0lv1eIzukaU6EiWOdy8MvBiWJUPPXH867dEBtPiXiB5?=
 =?us-ascii?Q?rsa7ONW/CNVw/BZ90EcD9EF/FEIYN3zsc/DPsSZ8faKf1ID0aaGnW156irw4?=
 =?us-ascii?Q?JLMLUl1EGxqmzA0EqJbCMWn4yY4keO6MaLqJ7To9Al6rga/abIlMmw+Id7JW?=
 =?us-ascii?Q?Rf/JCPs8KYhG6OwNndMnX7g1U0VS5XtWNiIwz078OqtSKJW/Nr5Pte0PrWhE?=
 =?us-ascii?Q?OhuoXG7SuEdeLfoVskFEZo5Zc2FZ+TD0Co0RyJ09NrD55uoVtn28I5SbjkHC?=
 =?us-ascii?Q?yZx6yaaazlMfop5zeG4yKHopuLvobx/6JPM1mlRQQ27WQYwYRrYTFIJiWIie?=
 =?us-ascii?Q?1oDFgyCxoFbzoun2jUehr1yiWgM7FWWI6hkOBQuwAnStC/DUlJjbUHnah/yZ?=
 =?us-ascii?Q?Gle3neor/lJ3bLlQn5JqrRW6S/Ufz4PmGe01bedY+Bv6Cd87a6acgwT3FXF5?=
 =?us-ascii?Q?SPoj4ZsY+UX6XVXeDwnozuWzELsnFsyYy0J4tk3GKj8WCjOeojm/RIEpng0D?=
 =?us-ascii?Q?O6xifqjziiILjQsR6kVNTsQi0n8ug25zv+vr4pKoSrZRv9w72kilw/vtmf1l?=
 =?us-ascii?Q?eWF26k//FJZnqTSkMhylp8Xn4i4ChUR7jMoHWAGwGHebV65RcMNiwXRbOslg?=
 =?us-ascii?Q?CaYTxIs46YZbVCOlbuvuvr2MnRl11I5Xs/CTHDMItEroBse6WUbiN7hURNac?=
 =?us-ascii?Q?7KcfykeGg+LgGxQRhufcpffkhj2NGtbMneZQqpOXb9WOr5JGSBvZA1axORmo?=
 =?us-ascii?Q?Wp0NnfLgfpNw3wsgxZ4gjx28cucL15nXgV0HJglj2mIEZGpTSqAmF4A/m/wD?=
 =?us-ascii?Q?VCTW8l5GQOAIy/qdtWPP3rZMn4dUPiwgaZ52k2weRSQBhdQWs+lnqXbxmlQP?=
 =?us-ascii?Q?M4vb8CBn8vMCsGw6VHQBw6bUi6IxzU9oVMsPYCLru60HTk7uIpObSYH95L6y?=
 =?us-ascii?Q?BiWoG7alxaRESwgz1lRDmLH2qkbUE26+/eh6ucyWoNCwJyb/mTgrkP76UmAC?=
 =?us-ascii?Q?XqMw9AueqH+WnMpy4FfoWuYIXbVappBti5bHq3+Lc3YAFjTfPNKN2wpGaETd?=
 =?us-ascii?Q?8I/aDwrNgwWk8OR8BVcMAm79OjMeJI9faSftXvsrVs+6GMb3fAWwGkStP+6R?=
 =?us-ascii?Q?F7ljz08nFK0H8EvC5z3zkFMSyDtsEp246ehMibdsj6CIp8Y/sJCoFDK0EH/Z?=
 =?us-ascii?Q?w8HlKzJxHoK/Aegqmt7yCOfGRGE8PzTDMNxwu57hb15JMn6nCnfoZ6+83HVG?=
 =?us-ascii?Q?RCp6DpO0IGlafwbw3sO8RbESiE88NXPzzWVQoFNte7dNJIL0tnP0AvKhFTp4?=
 =?us-ascii?Q?DHq/q6p+ij2Cz1Cz3TWMhvDzBf8fitLuAF8C+rkR/GJIwoYtiI0uD4P1NzfV?=
 =?us-ascii?Q?BGZHXI/73WXv0TzE0hXw7Njv5yhfYEp589V/4f9V7I5F7oJjE/qR7LfXBn4a?=
 =?us-ascii?Q?LXppZw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5181.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca5ccee-da49-4501-ebed-08d9c4d8bcfb
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 23:22:21.1617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rm9uSEHmExz+/N4cNbU1xPaqX0Z/fAqJTKxRA9nPV7sget3vyk5klZUSo/5sqCTbw1ipTTsSsvbe3QSe3kyoTuvt5xpPBxaQ2UHCLRzKNP4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3415
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Tuesday, December 21, 2021 2:00 AM
> To: Chen, Mike Ximing <mike.ximing.chen@intel.com>; linux-kernel@vger.ker=
nel.org
> Cc: arnd@arndb.de; gregkh@linuxfoundation.org; Williams, Dan J <dan.j.wil=
liams@intel.com>; pierre-
> louis.bossart@linux.intel.com; netdev@vger.kernel.org; davem@davemloft.ne=
t; kuba@kernel.org
> Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
>=20
> On Tue, 2021-12-21 at 00:50 -0600, Mike Ximing Chen wrote:
> > Add a DLB entry to the MAINTAINERS file.
>=20
> btw: Nice documentation
>=20
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9335,6 +9335,13 @@ L:	linux-kernel@vger.kernel.org
> >  S:	Supported
> >  F:	arch/x86/include/asm/intel-family.h
> >
> > +INTEL DYNAMIC LOAD BALANCER DRIVER
> > +M:	Mike Ximing Chen <mike.ximing.chen@intel.com>
> > +S:	Maintained
> > +F:	Documentation/ABI/testing/sysfs-driver-dlb
> > +F:	drivers/misc/dlb/
> > +F:	include/uapi/linux/dlb.h
> > +
> >  INTEL DRM DRIVERS (excluding Poulsbo, Moorestown and derivative chipse=
ts)
> >  M:	Jani Nikula <jani.nikula@linux.intel.com>
> >  M:	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>=20
> Section is not in the appropriate alphabetic order.
>=20
> dynamic should be after drm
>=20
Thanks. Will fix.

> > diff --git a/drivers/misc/dlb/dlb_main.c b/drivers/misc/dlb/dlb_main.c
> []
> > +// SPDX-License-Identifier: GPL-2.0-only
> []
> > +MODULE_LICENSE("GPL v2");
>=20
> Should use "GPL" not "GPL v2".
>=20
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1901282105450.1669@nanos.tec=
.linutronix.de/
>=20
We support v2 only.

*      "GPL"                           [GNU Public License v2 or later]
 *      "GPL v2"                        [GNU Public License v2]