MIME-Version: 1.0
References: <20211103114830.62711-1-alistair@alistair23.me>
 <20211103114830.62711-2-alistair@alistair23.me> <YYYk/uisKqPNgRu0@google.com>
 <CAKmqyKOFZOLpjMY+kj2CLibFhYJ3-tL+9+cKEVzgSn9Mzq30gw@mail.gmail.com>
 <YbbeDFJERtP0mAIQ@google.com> <20211218231823.49a72256@aktux>
In-Reply-To: <20211218231823.49a72256@aktux>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Wed, 22 Dec 2021 09:28:10 +1000
Message-ID: <CAKmqyKOtZ5AfVtNPYDNTMUjMRobZUwP7coTgEt94uze35Zxb7Q@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Alistair Francis <alistair@alistair23.me>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mylene Josserand <mylene.josserand@free-electrons.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?Q?Myl=C3=A8ne_Josserand?= <mylene.josserand@bootlin.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Dec 19, 2021 at 8:18 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> Hi,
>
> On Sun, 12 Dec 2021 21:45:48 -0800
> Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> [...]
> > > > This is also likely unsafe if controller is not completely shut off and
> > > > is capable of generating interrupts given input device is not yet
> > > > allocated.
> > >
> > > I have dropped the `IRQF_TRIGGER_FALLING |`
> > >
> > > I have tried to use level interrupts, but I can't get the device
> > > working with them.
> >
> > That is weird, does the interrupt controller support level interrupts?
> >
> I have set level interrupts via the devicetree,
> things seem to work on Kobo Clara HD:
> /proc/interrupts
> 203:      37402  gpio-mxc   6 Level     tt21000
>
>        touchscreen@24 {
>                 compatible = "cypress,tt21000";
>                 reg = <0x24>;
>                 pinctrl-names = "default","sleep";
>                 pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
>                 pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
>                 interrupt-parent = <&gpio5>;
>                 interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
>                 reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
>         };

I have tried using IRQ_TYPE_LEVEL_LOW as well, but the device doesn't
start correctly and the commands time out.

It works fine with IRQ_TYPE_EDGE_FALLING though.

Alistair

>
> Regards,
> Andreas