Date:   Tue, 21 Dec 2021 19:59:16 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Nadav Amit <namit@vmware.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        David Rientjes <rientjes@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Donald Dutile <ddutile@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>,
        Linux-MM <linux-mm@kvack.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v1 06/11] mm: support GUP-triggered unsharing via
 FAULT_FLAG_UNSHARE (!hugetlb)
Message-ID: <20211221235916.GI1432915@nvidia.com>
References: <4D97206A-3B32-4818-9980-8F24BC57E289@vmware.com>
 <CAHk-=whxvVQReBqZeaV41=sAWfT4xTfn6sMSWDfkHKVS3zX85w@mail.gmail.com>
 <5A7D771C-FF95-465E-95F6-CD249FE28381@vmware.com>
 <CAHk-=wgMuSkumYxeaaxbKFoAbw_gjYo1eRXXSFcBHzNG2xauTA@mail.gmail.com>
 <CAHk-=whYT0Q1F=bxG0yi=LN5gXY64zBwefsbkLoRiP5p598d5A@mail.gmail.com>
 <fca16906-8e7d-5d04-6990-dfa8392bad8b@redhat.com>
 <20211221010312.GC1432915@nvidia.com>
 <fd7e3195-4f36-3804-1793-d453d5bd3e9f@redhat.com>
 <CAHk-=wgQq3H6wfkW7+MmduVgBOqHeiXQN97yCMd+m1mM-1xCLQ@mail.gmail.com>
 <900b7d4a-a5dc-5c7b-a374-c4a8cc149232@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <900b7d4a-a5dc-5c7b-a374-c4a8cc149232@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WH/mUTbBGcSvgWJCFwF4CDQEhBC9Plh+NbS6pCTWrsjTx8OAN2zzmIc7x1rE?=
 =?us-ascii?Q?QWYuRsPdau3y3sXlzBgnGXkg+JX2P02uN4RHlYC1UsycSl1Ds+R/wv1/GfYF?=
 =?us-ascii?Q?ppmhD02418oCdCmKTl6SOX3AMq9fR6dJNh6pU1ZQChcAzebAHc5qNwnJiX6A?=
 =?us-ascii?Q?kpAnBmT1G1q4spLjnmbweMIkOf11Q6jseQIeMVi7YSKCHPEv1KQDN49mklX1?=
 =?us-ascii?Q?dNwgt5lPb2a4MbYT7A0smRMaSyKVNUktnk7UdypTYbMTDMFFTwtgbB2AQskC?=
 =?us-ascii?Q?alXem0qtX0fWv1PXl3i8GmsXMEGU2H3MMZoj0LHYiFszFWBLRvemu1jGYEEp?=
 =?us-ascii?Q?37eK1h+k0cYtxzCuK9b1QWOF0Z0cPQtw3ZU3sSznozzHgHZJTQ3EynApkVrK?=
 =?us-ascii?Q?RC/fjvQOCepTSDdTIMJns1Qfe917Z8LEKGMhvZ9tBPJN6Bq3BRiVXOQ/z2Ua?=
 =?us-ascii?Q?ImYe2eKrUWdzMniPydgi7/3VXSBI9XFz5kKjQeBPLH1fgHAw6GvBe3kWV4aG?=
 =?us-ascii?Q?D1F7aVEoDqxNxLBTQS8hE+jv1R99nbGH25Azm9JBB26Fm02XIeOTBQ0qJDAP?=
 =?us-ascii?Q?4YTukt3CRjQn8KYG1BCY8QH8p7UNo5eUO6/NjUTJcimzA3/KjxMOb0MVYM3V?=
 =?us-ascii?Q?BBZ5k8gD8Lo48MVoEvH6R31wcOcKbBkpH7axk+kM9lUkSpE/nJqPwD31qdJI?=
 =?us-ascii?Q?yrHr3vGZRrsycB9EtkYr86NzBGJH34a0OzNbEwXnWScGmSt26AbsfDiJk131?=
 =?us-ascii?Q?RhIhRE7dC/e4VwfnEFRxhRdmi/0YX0a6m01mJKj04/VDvQmlb07bxULekkwh?=
 =?us-ascii?Q?nPSaLQClyJ9/SBpq0Y5mURAufCbtG5jMiL7OCFlsDuu4Lf+ibbHjjiqk+riA?=
 =?us-ascii?Q?ldX/CeP5reIibjPe/PbT8MRA9EFEkYuaQ+iSL2EdpbnxHSlY9ndX+/dwU/Yi?=
 =?us-ascii?Q?BJrEqCgOwzJHN86n+IrBA3fuvucn33KLzNCsT74qwARBIWHQDZTjd917dm2U?=
 =?us-ascii?Q?u46VsIBkumo5EMxaHwZF2UoqFneLwOIbtelv0gxk687qLqfhnOEEovHMHJ39?=
 =?us-ascii?Q?7GfMUJgahBkSagIGaPkN53HbngKKRFUTqgjKdj1L8g0Op/4gQOdL9ljuYzVK?=
 =?us-ascii?Q?FCh7AyFHp7npj+XgiR7WeMsny3FYvw8RcrqCAnmlUdNACTeFPjcUUevxEvgS?=
 =?us-ascii?Q?hjj5I1InnEhjCalb34WgDd7bBqeT6jgv18NupZkM0//SBdvbdhi2mzkmaa/D?=
 =?us-ascii?Q?8KrNkLP65+WdnGY/DFySqKPNvf8MQrx0brGiVJgJJzgl2kNaTXHqs/+rHlUq?=
 =?us-ascii?Q?VTDL1hqjAFJe6tQf9L/TMqILQO+LdUb9b9e9VOLExYWiK45uXxMsDo+0w6Bl?=
 =?us-ascii?Q?9q6tNRlUbNYZJhwdKSuG7m7aOfj1Q5lER63YVYu49NuVfYlVna5vWd8A6kRM?=
 =?us-ascii?Q?hJkMTO9F4trb7j48ZfP1yfLWMT1DA4n1k109tAQbY1933/S7BDAbffhKoVAj?=
 =?us-ascii?Q?Zj2Gw4oBGNt0bJTkFrfJ22LKSZhvvTXl6knb9woXO9HswbdRg/PkD1AQGm93?=
 =?us-ascii?Q?sFxRW+Iv02kzeerIGAM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e83d047b-b57f-4bbd-08e3-08d9c4dde709
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 23:59:19.5393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ymD70s8/pD8rQRwalllXwFpk4hi4V5Xg+W4MEn+Prfi1yRBKXILdUePrdtOoZAI1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5206
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 21, 2021 at 06:40:30PM +0100, David Hildenbrand wrote:

> What adds complexity to correctly maintain the "exclusive" state are at
> least:
> * KSM (might be harder, have to think about it)

I know little about it, but isn't KSM like fork where it is trying to
WP pages with the intention of copying them? Shouldn't KSM completely
reject WP'ing a page that is under any kind of writable GUP?

Jason