MIME-Version: 1.0
References: <20211222052457.1960701-1-shakeelb@google.com> <CAMZfGtWb7pBTbX_radgv50y12aNBZxP3aeTQr91=7qQacQFE9w@mail.gmail.com>
In-Reply-To: <CAMZfGtWb7pBTbX_radgv50y12aNBZxP3aeTQr91=7qQacQFE9w@mail.gmail.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Tue, 21 Dec 2021 22:06:00 -0800
Message-ID: <CALvZod4vqUC248R_1PmvvfkYEu9oBPN48rtCiWwSZ0UGaE_bVA@mail.gmail.com>
Subject: Re: [PATCH v2] memcg: add per-memcg vmalloc stat
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>, Roman Gushchin <guro@fb.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 21, 2021 at 9:50 PM Muchun Song <songmuchun@bytedance.com> wrote:
>
> On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt <shakeelb@google.com> wrote:
> >
> [...]
> > @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages)
> >                 unsigned int page_order = vm_area_page_order(area);
> >                 int i;
> >
> > +               mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC,
> > +                                    -(int)area->nr_pages);
>
> The cast can go away since the type of 3rd parameter of
> mod_memcg_page_state() is int but not long. I suggest
> to remove it. Anyway

Andrew, please remove this cast of the third param when you add this
patch in the mm tree.

>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.