Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E0BC433EF for ; Wed, 22 Dec 2021 07:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242976AbhLVHZK (ORCPT ); Wed, 22 Dec 2021 02:25:10 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21]:59194 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231422AbhLVHZI (ORCPT ); Wed, 22 Dec 2021 02:25:08 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowAA3P5+_0sJhvqi7BA--.45819S2; Wed, 22 Dec 2021 15:24:47 +0800 (CST) From: Jiasheng Jiang To: hdegoede@redhat.com, axboe@kernel.dk, p.zabel@pengutronix.de Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] ata: libahci_platform: Remove abundant check Date: Wed, 22 Dec 2021 15:24:46 +0800 Message-Id: <20211222072446.1096168-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAA3P5+_0sJhvqi7BA--.45819S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Gry8GF1rXrW3ZFy7ZrW5Wrg_yoW3KrX_Jw 18WFW7Jr4rCF1vqw17tr13uFWSyas8urn2vF1kt3ZIg3s8X345uFy7Zr4UAa1j9F10yr95 AFsrCry3C34SyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8CwCF 04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr 1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUPb18UUUUU= X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It can be found that platform_get_irq() returns nagative code but not null when fails. The comment of the platform_get_irq clearly shows that. Therefore it should be better to remove the useless check. Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c") Signed-off-by: Jiasheng Jiang --- drivers/ata/libahci_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c index b2f552088291..5ec68f138c28 100644 --- a/drivers/ata/libahci_platform.c +++ b/drivers/ata/libahci_platform.c @@ -587,8 +587,6 @@ int ahci_platform_init_host(struct platform_device *pdev, dev_err(dev, "no irq\n"); return irq; } - if (!irq) - return -EINVAL; hpriv->irq = irq; -- 2.25.1