Date:   Tue, 21 Dec 2021 23:50:39 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     "David E. Box" <david.e.box@linux.intel.com>
Cc:     Rajat Jain <rajatja@google.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        francisco.munoz.ruiz@linux.intel.com, nirmal.patel@linux.intel.com,
        jonathan.derrick@linux.dev, lorenzo.pieralisi@arm.com,
        hch@infradead.org, kw@linux.com, robh@kernel.org,
        bhelgaas@google.com, michael.a.bottini@linux.intel.com,
        rafael@kernel.org, me@adhityamohan.in, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices
Message-ID: <YcLYz0x5oawOEHnI@infradead.org>
References: <20211220172848.GA1006510@bhelgaas>
 <e87a297cc74cca02fa1a8f5aa9562489a4db26b3.camel@linux.intel.com>
 <CACK8Z6F812_DYVr=sxRXxhtPxyCw206U=jW6CFt6T-MyKJXMgQ@mail.gmail.com>
 <9b540d4f11bb4e2e1422b641df1f5e84aa68602f.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9b540d4f11bb4e2e1422b641df1f5e84aa68602f.camel@linux.intel.com>
Precedence: bulk

On Tue, Dec 21, 2021 at 01:11:26PM -0800, David E. Box wrote:
> The reason why BIOS is not programming these values is because when VMD is
> enabled the ports are not visible to BIOS. This would apply to any BIOS
> including those used by ChromeOS.
> And because BIOS doesn't see these ports ...

Isn't VMD enabled by the BIOS?  The bios should be able see them the
same way as Linux does.  But given that the whole point of VMD is to hide 
these ports from Windows it obviously doesn't.  For Linux and thus for
ChromeOS VMD is completely pointless, so give that the ChromeOS people
aren't as dumb as some people at Intel I'm pretty sure they won't enable
it and just use the ports as normal one and avoid this whole
self-inflicted pain.

If only Intel could give the OS a way to disable VMD at runtime and
discover the actual ports, then we would not have this whole nightmare
of having to support it.