Subject: Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP
 support
To:     Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Viresh Kumar <vireshk@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Lee Jones <lee.jones@linaro.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Nishanth Menon <nm@ti.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Michael Turquette <mturquette@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-clk@vger.kernel.org, David Heidelberg <david@ixit.cz>
References: <20211130232347.950-1-digetx@gmail.com>
 <20211130232347.950-9-digetx@gmail.com>
 <21212ddb-205f-71d6-0199-d75768eaf32c@nvidia.com>
 <41edc53b-5ed1-d524-2546-c3d1ee6cdea4@gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <6652ac84-36f5-0e43-65fa-04786f384f21@nvidia.com>
Date:   Wed, 22 Dec 2021 09:47:35 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <41edc53b-5ed1-d524-2546-c3d1ee6cdea4@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUZ6WnZPZFFOSlUxc1llaFpuaFU4SSt2K2RVQkRvVjBWS0dhbWFlN2xZVlFp?=
 =?utf-8?B?d3lMTUhFVnRWQUFhbWN1UklrQnMydzhDWHp5blBaQ3NsS0NaWDR4NUtVeVll?=
 =?utf-8?B?b09hcmdYS1MrR3dFaHNqSXhva0JocDhBZy9UcGpTZ1FsYVN4UkROUitWdGRY?=
 =?utf-8?B?eGdYVUtoVytBNk93WkhaSFhNVFhweERYcHYrbTVFKzRTamZ5eHFuZ0ZDdkFp?=
 =?utf-8?B?Sk4vWStFc3BrOExDTTR6Q2t0c0drUFlwWnZ1VmdITGlkcUZhcGY2TncxKzZq?=
 =?utf-8?B?YmlmQ1I5VU9QQmFkUVd1QzFHdEVSVjFsRE00RGNSdjloNWpwakpZRFhvWDE5?=
 =?utf-8?B?ZmFINnhRdFRpa0VJZTNBNUNIWHBtRmYyYzJCcVVxbXBBYUg4dEkwVE5mNzRV?=
 =?utf-8?B?b240QjZSNnJ1ZTBNbG96ZHdjaUlPU2RaMmxESk8rbWZRMUtlMTM2Y0YwbTA5?=
 =?utf-8?B?TVNOekdIcmM3enVnVHZ5RVR6bVo4SlFwZVhJcS9Nbld1bkFySTEwd3Voa1dK?=
 =?utf-8?B?Y2x4Ny9XeU9LQVdBVW9IY2tjSmdUMzN4Q1owTUpobWJ5eWdHaUxaZEduTFFS?=
 =?utf-8?B?aFcwRmRhc3RENytNYjQ0aDVGS3I2TWM2WjY4UmdwQ2xCMXlWdEtPQjZERDJZ?=
 =?utf-8?B?Y0Vlb0x3b20vSjJTVTVlTmx1cUkxNEs4VmlIQWVVdThaQzdzalBaUnNjenR3?=
 =?utf-8?B?cGVpNDZ1cTQzV2kyWDRwUE1zMHQ0Q0hKNmtOUmxEVFpYdysrcmN1cVp4dVh0?=
 =?utf-8?B?OUpBSCtJdVlqTVBVdjNiTmNiQnViMmZ2WUlrSFA0ZVBnWFJIeWVXVk9vRStj?=
 =?utf-8?B?cFZVMU95ZThBWWtmZ0d4Z2p5T3FqU3lxMU9Xc2kyU0JxVFhCUFZoMWRWT25n?=
 =?utf-8?B?aUZSZjZadE4yaGN5Z2VxdDN4eW5ITVp1OEZhckJhMGJPZmJROUpxR05Db2ly?=
 =?utf-8?B?OFViMHdMYnFsYTVoa3BURmN4cko3T2FZM2ZnMi80NjNxL2ZWSGtMalI4R2xa?=
 =?utf-8?B?RUNKdS9ycTZweHR4aHZGaHoxL2krMUlQYkkxY20vNFFhRldiVVpiQnNXRG9n?=
 =?utf-8?B?THNYUTdFaXAzLzlmeXlNTldwRnY5bXJTbnRZeUFQZjI1bEliMjd4V21pdmg1?=
 =?utf-8?B?VjZYYm1vbXVLdlRsQzI4cXdHUFFWMUo4dGVuVTJYc0U1aXdwWWtYRXBjUi8w?=
 =?utf-8?B?eVpidjBIK3B1NDRpMFdQZjdDQlMzMkpyQzFwOE5YUS9nWlVMbDhoYm5jVWFF?=
 =?utf-8?B?Q2NPWVVDMXRNNkVNd2RTc0JsTURqMllPUnhLa0w3QXZ6WGF6Tk4xc0VpN25R?=
 =?utf-8?B?UG1mSEFnWXJRczZkQjhwOU5udnlSaktvSU1pS3VOaGlYd0FXazR0dDRjUzcz?=
 =?utf-8?B?Nk84QzROOXVTVWU5b1hZbVRzemlkOFlmYzFVd25kQko1MGd4eTNKdGE5YkRq?=
 =?utf-8?B?azM2UU5UWVR5dS9ZNmwvQXdKaWFwWVZFUUZJdFFiRG4xRS9wZkpOT2RjMEtt?=
 =?utf-8?B?TWFBYXFBL0hZQU9yTUhONHdKcTZwcVF0ckZnM2cydkoxWFQ3TTllQmFLOUNv?=
 =?utf-8?B?UDBxS3lEeS9ZVFJPbnQ4R1UzQlkvVmRvM2Q5VDducjMza2pkS29BZHFaSitL?=
 =?utf-8?B?UXBwQzg2VzZyRkhOOFpyMHBpYmdWQ1pTdVNORFZWR0w2c3g2RllhWWlBeUdl?=
 =?utf-8?B?UEloaEx4Mzh0TjR3ZGJqOTB4SVdYcjBLMlYxN0lHY2c4L2UrTXpMejJtaFY2?=
 =?utf-8?B?dUdIMXR4WFRUYzNJOGN4dW9KelpvNEF5ZE1TVURkVkt3UmlXWFNLaWczc1FP?=
 =?utf-8?B?YnY5ZFd0Rjg2QXZRTmxTc01JVXBFeXh6T0QxNHJndmRET0tJWDJjKzZSemFY?=
 =?utf-8?B?WVBBOWpzRHYvRVdxYlJxeTBVLzhadEQrd1AvZThRRGV0TUpSQTAzQjZCZFBk?=
 =?utf-8?B?VUdZNkJ3SndnRnp5QVNRT3Z1ZitHdytXc0wvRmNUNUJXbG03bEJkQXB2b1V2?=
 =?utf-8?B?djB4MmtaeFJWOUczV1doMzdGRVZXN3A5TG1QcDJvUUxYUXNDeU9hYXl5SG94?=
 =?utf-8?B?NmVnMnI0MC9LRkh1djhvdFVJR1pwcXZIbDF2L2Q0enpQT3dWVXo5dFNRZ0VI?=
 =?utf-8?B?VkVLWjE5d3pBN3ZGb09MOS9GSzcxSlpnTkpKQmh5cFRsOW4ySFVjNTBXWldO?=
 =?utf-8?Q?CQj+yUjcdbL26oT8KzZXU8s=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6d0281-5ac9-44f4-b857-08d9c5301b7a
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 09:47:46.4106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfcngIYu/3z1iepuyxGiewWriAKBLluLYsWRV3rXvKJKr0T2px1OB0YHd9omFomuQWQQ5hskQEwnP0zWi/HULw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5443
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/12/2021 20:58, Dmitry Osipenko wrote:
> Hi,
> 
> Thank you for testing it all.
> 
> 21.12.2021 21:55, Jon Hunter пишет:
>> Hi Dmitry, Thierry,
>>
>> On 30/11/2021 23:23, Dmitry Osipenko wrote:
>>> Add runtime PM and OPP support to the Host1x driver. For the starter we
>>> will keep host1x always-on because dynamic power management require a
>>> major
>>> refactoring of the driver code since lot's of code paths are missing the
>>> RPM handling and we're going to remove some of these paths in the future.
>>
>>
>> Unfortunately, this change is breaking boot on Tegra186. Bisect points
>> to this and reverting on top of -next gets the board booting again.
>> Sadly, there is no panic or error reported, it is just a hard hang. I
>> will not have time to look at this this week and so we may need to
>> revert for the moment.
> 
> Only T186 broken? What about T194?

Yes interestingly only Tegra186 and no other board.

> Which board model fails to boot? Is it running in hypervisor mode?

This is Jetson TX2. No hypervisor.

> Do you use any additional patches?

No just plain -next. The tests run every day on top of tree.

> Could you please test the below diff? I suspect that
> host1x_syncpt_save/restore may be entirely broken for T186 since we
> never used these funcs before.
> 
> --- >8 ---
> 
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> index f5b4dcded088..fd5dfb875422 100644
> --- a/drivers/gpu/host1x/dev.c
> +++ b/drivers/gpu/host1x/dev.c
> @@ -580,7 +580,6 @@ static int __maybe_unused
> host1x_runtime_suspend(struct device *dev)
>   	int err;
> 
>   	host1x_intr_stop(host);
> -	host1x_syncpt_save(host);
> 
>   	err = reset_control_bulk_assert(host->nresets, host->resets);
>   	if (err) {
> @@ -596,9 +595,8 @@ static int __maybe_unused
> host1x_runtime_suspend(struct device *dev)
>   	return 0;
> 
>   resume_host1x:
> -	host1x_setup_sid_table(host);
> -	host1x_syncpt_restore(host);
>   	host1x_intr_start(host);
> +	host1x_setup_sid_table(host);
> 
>   	return err;
>   }
> @@ -626,9 +624,8 @@ static int __maybe_unused
> host1x_runtime_resume(struct device *dev)
>   		goto disable_clk;
>   	}
> 
> -	host1x_setup_sid_table(host);
> -	host1x_syncpt_restore(host);
>   	host1x_intr_start(host);
> +	host1x_setup_sid_table(host);


Thanks! Will try this later, once the next bisect is finished :-)

Jon

-- 
nvpublic