Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E3DC43219 for ; Wed, 22 Dec 2021 10:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244318AbhLVK4u (ORCPT ); Wed, 22 Dec 2021 05:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240085AbhLVK4t (ORCPT ); Wed, 22 Dec 2021 05:56:49 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F1BC061746 for ; Wed, 22 Dec 2021 02:56:47 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id d9so4168002wrb.0 for ; Wed, 22 Dec 2021 02:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=3Wks2OpuoB00uHRdh5JUOv2eXhyxD1JIeK8fHzyUvqM=; b=P4Xys96R8sOLs5LvpYi8S+iGyJy/CyJ/hliNHjWaDR72pb5VG5lXrnhBXmj4y0RlHX 4v9sLZtMm8BVyxq+sRO25uelCX6izdp05ULp9hvwm/Mglo8UYDote5AH36detwLyX7Vm mUvXr5jvb1YHSfeHVoPa0KzR46C3uFcGlEGAt7GFJWZdQ3iVBAgP83nrolccxZknIuWW dCuuv1cj9ZlhKQ5xb/0JrTTtUe1cufNZnJX0cPDPa6p5zWK+99K/zeKfTycRnnXgyO5M 8dza5aq6D3S1rkIrUbC8l5cPMlq0UCY/lzfkJHQcOjH5CvLXP44Cglx13sliu0dbxC+d a37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3Wks2OpuoB00uHRdh5JUOv2eXhyxD1JIeK8fHzyUvqM=; b=LUVx2o3Uf3HmBwFCNTIJX0yX+S9ycQNIkfQq0Xb1IP+mfKmfsmTTrFahLT2vPFEEXx RoN1uttDSk0XiziyHjGR7aQAD5XMTtnklsNu8l0U5BTuA7w+ZP9qMvkCg/vI2vGcuX18 aG4txCPQbCZofA56yuwz4vQnQNNBFVAlpJmLc4EzcUBxRrxjT2Ht3DlMs7LTIGQivsMW SO/78ga1BfANPljfrc20snflmzkhOpIGEczjReyzJdzKB70068z51hcQqbNTSoea3oT/ KMenadYaq8T2iUAQeYT87UVwbzMXDSGc2SS3IhozWhIt8iDYIPx1npcbTijG0IviVzvK CZQg== X-Gm-Message-State: AOAM5324Ek18Ma88OVi7Fb0AgYeFcKMwuy+6wyZ2SZ88WluDIAgJl96i sYvHz7L3zVmut+maG5WcosQt/Q== X-Google-Smtp-Source: ABdhPJzPy9qHrxvmsh7Kw2oL3n3gfjoGIN/UMGaa134hOuMY2k9I3qz20YIwWw5VJKZnnyWplusSuQ== X-Received: by 2002:adf:bb4a:: with SMTP id x10mr1714179wrg.269.1640170606402; Wed, 22 Dec 2021 02:56:46 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id l19sm1507984wmq.22.2021.12.22.02.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 02:56:45 -0800 (PST) Date: Wed, 22 Dec 2021 10:56:43 +0000 From: Lee Jones To: Marijn Suijten , Daniel Thompson , phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211116120213.n7qxqfi62lrxhyl7@maple.lan> <20211221233131.rwjjojuawgffr2gf@SoMainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211221233131.rwjjojuawgffr2gf@SoMainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Dec 2021, Marijn Suijten wrote: > On 2021-11-16 15:42:15, Lee Jones wrote: > > On Tue, 16 Nov 2021, Daniel Thompson wrote: > > > > > Hi Lee > > > > > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > > > This patchset fixes WLED's handling of enabled-strings: besides some > > > > cleanup it is now actually possible to specify a non-contiguous array of > > > > enabled strings (not necessarily starting at zero) and the values from > > > > DT are now validated to prevent possible unexpected out-of-bounds > > > > register and array element accesses. > > > > Off-by-one mistakes in the maximum number of strings, also causing > > > > out-of-bounds access, have been addressed as well. > > > > > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > > > the set should now have my R-b: attached to them. > > > > I can see that. Nothing for you to worry about. > > > > I'll apply these when I conduct my next sweep, thanks. > > Thanks for that Lee! Has the next sweep already passed by? Seems > everyone is preparing for the 5.17 merge window but these patches > haven't yet landed on the backlight tree [1]. I'd appreciate it if we > can make them appear in the 5.17 window :) No need to panic. v5.17-rc1 isn't due to be cut for either 3.5 or 4.5 weeks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog