Date:   Wed, 22 Dec 2021 11:09:56 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Message-ID: <YcMHhJTsQMLDRRsN@google.com>
References: <20211220144654.926112-1-pgwipeout@gmail.com>
 <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
 <YcGU6pQqfEPBqjrO@google.com>
 <4963E4A2-63B4-48A1-BDDD-5F9D07D71598@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4963E4A2-63B4-48A1-BDDD-5F9D07D71598@public-files.de>
Precedence: bulk

On Tue, 21 Dec 2021, Frank Wunderlich wrote:

> Am 21. Dezember 2021 09:48:43 MEZ schrieb Lee Jones <lee.jones@linaro.org>:
> >On Mon, 20 Dec 2021, Frank Wunderlich wrote:
> >
> >> Hi
> >> 
> >> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> >> > Von: "Peter Geis" <pgwipeout@gmail.com>
> >> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client
> >*client)
> >> >  	if (pm_power_off == rk808_pm_power_off)
> >> >  		pm_power_off = NULL;
> >> >
> >> > +	if (of_property_read_bool(np,
> >"rockchip,system-power-controller"))
> >> > +		unregister_restart_handler(&rk808_restart_handler);
> >> > +
> >> >  	return 0;
> >> >  }
> >> 
> >> this change misses a declaration
> >> 
> >> struct device_node *np = client->dev.of_node;
> >
> >How did this compile when you tested it?
> 
> Here i have squashed the change in:
> 
> https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f
> 
> With the change i can compile it...

Not sure I understand.

Please make sure all patches you send for inclusion into the Linux
kernel are fully tested.  They should also be bisectable i.e. not
depend on patches applied *on top*.

> But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely.
> regards Frank

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog