Date:   Wed, 22 Dec 2021 12:53:59 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Frank Wunderlich <frank-w@public-files.de>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Message-ID: <YcMf56MvFv0ym7E5@google.com>
References: <20211220144654.926112-1-pgwipeout@gmail.com>
 <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
 <YcGU6pQqfEPBqjrO@google.com>
 <4963E4A2-63B4-48A1-BDDD-5F9D07D71598@public-files.de>
 <YcMHhJTsQMLDRRsN@google.com>
 <trinity-4d94e8dd-1499-4d5f-84c3-85075a4085dd-1640172673779@3c-app-gmx-bs44>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <trinity-4d94e8dd-1499-4d5f-84c3-85075a4085dd-1640172673779@3c-app-gmx-bs44>
Precedence: bulk

On Wed, 22 Dec 2021, Frank Wunderlich wrote:

> > Gesendet: Mittwoch, 22. Dezember 2021 um 12:09 Uhr
> > Von: "Lee Jones" <lee.jones@linaro.org>
> > An: "Frank Wunderlich" <frank-w@public-files.de>
> > > Here i have squashed the change in:
> > >
> > > https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f
> > >
> > > With the change i can compile it...
> >
> > Not sure I understand.
> >
> > Please make sure all patches you send for inclusion into the Linux
> > kernel are fully tested.  They should also be bisectable i.e. not
> > depend on patches applied *on top*.
> >
> > > But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely.
> > > regards Frank
> 
> only v1 was sent by me :)
> 
> v4 is compilable and works on rk809 (Bananapi r2 pro)

My comments are directed at whoever sent patches without testing.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog