Subject: Re: [PATCH] perf pmu: Fix event list for uncore PMUs
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Jiri Olsa <jolsa@redhat.com>, <peterz@infradead.org>,
        <mingo@redhat.com>, <mark.rutland@arm.com>,
        <alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>,
        <irogers@google.com>, <kan.liang@linux.intel.com>,
        <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1639670017-74918-1-git-send-email-john.garry@huawei.com>
 <YcGJJ2g+i5qWea7d@krava> <bbf9c0b4-c048-3adf-5282-2355aa648acf@huawei.com>
 <YcGf/d5PPqqyXxUW@krava> <43e185f6-9fa7-6ae1-e4fd-c90c6a50f68f@huawei.com>
 <YcI9twHCIiFyUDOu@kernel.org>
From:   John Garry <john.garry@huawei.com>
Message-ID: <d987a1a9-3c3f-9efb-24c7-22e18d8d63e4@huawei.com>
Date:   Wed, 22 Dec 2021 13:08:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <YcI9twHCIiFyUDOu@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/12/2021 20:48, Arnaldo Carvalho de Melo wrote:
>> Now thinking a bit more I am not confident that this patch is a full fix.
>>
>> arm have heterogeneous CPU systems as well - which are not "hybrid" - and I
>> need to ensure that aliasing is still working properly there, as I think
>> that this following check would stop removing duplicates there:
>>
>> +	/* uncore PMUs */
>> +	if (!alias_a->is_cpu && !alias_b->is_cpu)
>> +		return true;
>> +	return false;
> I was about to process this, do you think its better to revert the
> original patch while this gets fixed?

I think that the v2 should now be ok.

@jirka, can you kindly help to check that?

BTW, my patch is based on v5.16-rc5 . I assumed that I would need to be 
based on acme/perf/urgent, but that seems to be based on 5.15

Thanks,
John