MIME-Version: 1.0
References: <20211220144654.926112-1-pgwipeout@gmail.com> <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
 <YcGU6pQqfEPBqjrO@google.com> <4963E4A2-63B4-48A1-BDDD-5F9D07D71598@public-files.de>
 <YcMHhJTsQMLDRRsN@google.com> <trinity-4d94e8dd-1499-4d5f-84c3-85075a4085dd-1640172673779@3c-app-gmx-bs44>
 <YcMf56MvFv0ym7E5@google.com>
In-Reply-To: <YcMf56MvFv0ym7E5@google.com>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Wed, 22 Dec 2021 08:19:57 -0500
Message-ID: <CAMdYzYpYumXLEZYNadfHHGZN16ismT2JOMO8bGEegXP69sT3sw@mail.gmail.com>
Subject: Re: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Frank Wunderlich <frank-w@public-files.de>,
        Robin Murphy <robin.murphy@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 22, 2021 at 7:54 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 22 Dec 2021, Frank Wunderlich wrote:
>
> > > Gesendet: Mittwoch, 22. Dezember 2021 um 12:09 Uhr
> > > Von: "Lee Jones" <lee.jones@linaro.org>
> > > An: "Frank Wunderlich" <frank-w@public-files.de>
> > > > Here i have squashed the change in:
> > > >
> > > > https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb=
940256de77807ed620f
> > > >
> > > > With the change i can compile it...
> > >
> > > Not sure I understand.
> > >
> > > Please make sure all patches you send for inclusion into the Linux
> > > kernel are fully tested.  They should also be bisectable i.e. not
> > > depend on patches applied *on top*.
> > >
> > > > But in v4 (patch is tagged as v3 too) the of_property_read_bool was=
 dropped completely.
> > > > regards Frank
> >
> > only v1 was sent by me :)
> >
> > v4 is compilable and works on rk809 (Bananapi r2 pro)
>
> My comments are directed at whoever sent patches without testing.

Apologies, due to an unfortunate set of circumstances I missed the
build failed and I was using a stale kernel.

>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Senior Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog