Date:   Wed, 22 Dec 2021 14:55:39 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     hch <hch@lst.de>
Cc:     Richard Weinberger <richard@nod.at>,
        anton ivanov <anton.ivanov@cambridgegreys.com>,
        x86 <x86@kernel.org>, linux-um <linux-um@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: remove set_fs for UML
Message-ID: <YcMuW88cOBNXAdb/@zn.tnic>
References: <20211215165612.554426-1-hch@lst.de>
 <1202521211.191037.1640120703350.JavaMail.zimbra@nod.at>
 <20211222081753.GB22041@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211222081753.GB22041@lst.de>
Precedence: bulk

On Wed, Dec 22, 2021 at 09:17:53AM +0100, hch wrote:
> On Tue, Dec 21, 2021 at 10:05:03PM +0100, Richard Weinberger wrote:
> > So far UML seems to work with these changes applied. :-)
> > I have applied both patches to my UML tree for now, I assume x86 maintainers are fine with
> > patch 1/2?
> 
> Looks like patch 1 needs this fixup for some configurations, where
> pci.h doesn't get pulled into kvm by other means.
> 
> But we probably want an ACK from the x86 maintainers to be sure anyway..

I don't see why not so

Acked-by: Borislav Petkov <bp@suse.de>

Should I take the first one along with this hunk below?

> diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c
> index 0c76c45fdb686..fad546df0bbac 100644
> --- a/arch/x86/kvm/mmu/spte.c
> +++ b/arch/x86/kvm/mmu/spte.c
> @@ -16,6 +16,7 @@
>  #include "spte.h"
>  
>  #include <asm/e820/api.h>
> +#include <asm/memtype.h>
>  #include <asm/vmx.h>
>  
>  static bool __read_mostly enable_mmio_caching = true;

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette