Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751517AbXA0K4l (ORCPT ); Sat, 27 Jan 2007 05:56:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751433AbXA0K4k (ORCPT ); Sat, 27 Jan 2007 05:56:40 -0500 Received: from smtp.osdl.org ([65.172.181.24]:48660 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbXA0K4i (ORCPT ); Sat, 27 Jan 2007 05:56:38 -0500 Date: Sat, 27 Jan 2007 02:51:37 -0800 From: Andrew Morton To: "Eric W. Biederman" Cc: , , , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com, minyard@acm.org, openipmi-developer@lists.sourceforge.net, , linux-mips@linux-mips.org, ralf@linux-mips.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-390@vm.marist.edu, paulus@samba.org, linuxppc-dev@ozlabs.org, lethal@linux-sh.org, linuxsh-shmedia-dev@lists.sourceforge.net, , vojtech@suse.cz, clemens@ladisch.de, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-parport@lists.infradead.org, andrea@suse.de, tim@cyberelk.net, philb@gnu.org, aharkes@cs.cmu.edu, coda@cs.cmu.edu, codalist@TELEMANN.coda.cs.cmu.edu, aia21@cantab.net, linux-ntfs-dev@lists.sourceforge.net, mark.fasheh@oracle.com, kurt.hackel@oracle.com Subject: Re: [PATCH 49/59] sysctl: Move init_irq_proc into init/main where it belongs Message-Id: <20070127025137.9a2c65bb.akpm@osdl.org> In-Reply-To: <1168965684147-git-send-email-ebiederm@xmission.com> References: <1168965684147-git-send-email-ebiederm@xmission.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1702 Lines: 59 On Tue, 16 Jan 2007 09:39:54 -0700 "Eric W. Biederman" wrote: > From: Eric W. Biederman - unquoted > > Signed-off-by: Eric W. Biederman > --- > init/main.c | 3 +++ > kernel/sysctl.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/init/main.c b/init/main.c > index 8b4a7d7..8af5c6e 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -691,6 +691,9 @@ static void __init do_basic_setup(void) > #ifdef CONFIG_SYSCTL > sysctl_init(); > #endif > +#ifdef CONFIG_PROC_FS > + init_irq_proc(); > +#endif > > do_initcalls(); > } > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 600b333..7420761 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1172,8 +1172,6 @@ static ctl_table dev_table[] = { > { .ctl_name = 0 } > }; > > -extern void init_irq_proc (void); > - > static DEFINE_SPINLOCK(sysctl_lock); > > /* called under sysctl_lock */ > @@ -1219,7 +1217,6 @@ void __init sysctl_init(void) > { > #ifdef CONFIG_PROC_SYSCTL > register_proc_table(root_table, proc_sys_root, &root_table_header); > - init_irq_proc(); > #endif > } sparc64: init/main.c: In function `do_basic_setup': init/main.c:707: warning: implicit declaration of function `init_irq_proc' I couldn't be bothered working out how init/main.c is supposed to get at its declaration of init_irq_proc(). It's not allowed to include linux/irq.h. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/