Subject: Re: [PATCH] ipc/sem: do not sleep with a spin lock held
To:     Manfred Spraul <manfred@colorfullife.com>, cgel.zte@gmail.com,
        akpm@linux-foundation.org
Cc:     shakeelb@google.com, rdunlap@infradead.org, dbueso@suse.de,
        unixbhaskar@gmail.com, chi.minghao@zte.com.cn, arnd@arndb.de,
        linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
References: <20211222081026.484058-1-chi.minghao@zte.com.cn>
 <63840bf3-2199-3240-bdfa-abb55518b5f9@colorfullife.com>
 <1181e64b-94c0-908a-b9e9-1a38f4610430@virtuozzo.com>
 <02171384-9d1e-19fa-5fa1-5f84b720a03e@virtuozzo.com>
 <4d786a02-1560-25ed-4603-8419672ec044@colorfullife.com>
From:   Vasily Averin <vvs@virtuozzo.com>
Message-ID: <d89356b2-c7d8-a3d0-5d3f-1ef37b631193@virtuozzo.com>
Date:   Wed, 22 Dec 2021 20:38:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <4d786a02-1560-25ed-4603-8419672ec044@colorfullife.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGI4RzhXdjBSRERWLzlvYktHY0Z1bTVsYlJRUFhEUGFrME55V0Y1ZkJqOUJG?=
 =?utf-8?B?MFg4UWhVYWZwSzJVVk9nYy9YNzJtdVBZUlZWbXZIUVBGUWR2MXNxcXdTbkF3?=
 =?utf-8?B?ZTVSa1V0YVBLL0NxRGMvT0ZUMWg0SlNlcDA2ZHdtTmtBaVFjSG1oSzhVY3JS?=
 =?utf-8?B?MEF3dThjallHUVczT2ZWaG9DamJqeG9tNXQ1azRZSGhsSnFPc2prSFVZZUk4?=
 =?utf-8?B?U1FMVnRFWmpNc29ZN3lDdzdWbU9hQ0lldkd5UHBHSU9kb1dQazBuQkFJLzQx?=
 =?utf-8?B?QXg2ZlV1K3dIdlFLOUtGcVl3Y25ZaTN6Qm91Znpab1Q5SU00TkllOEQzY0xM?=
 =?utf-8?B?c1BpbnQrNnRWckZFeERRNEZGTVYvcmFNT0U0T003WGlXd2FuTGhPY0hTaXVm?=
 =?utf-8?B?M1ljNnJ0NDI0YWU5WCsxeW5FRW03Z0RVVjBrbDlHcFhRU2VjeDVHVlBJcXJj?=
 =?utf-8?B?RnlNRXMyZmh1ekQxOEc1YXU2TjdaRDBveDF4SnFsOEFNekRvNW1lM3pqRXZk?=
 =?utf-8?B?QUR3UEI4S3Q3QjRXQkxaamR0RzFHM25uWkh4MytkYlBPTWRmMkplNE1uTXJ5?=
 =?utf-8?B?d1BKQnMwQ1ZEazJic1g2ZmJSUUFqdVZNZXNDdHVrelZEWXl5NERyMmMveTlw?=
 =?utf-8?B?elNUaXRtKzRZWXJQQnRoNkNCV2Z6SWpPazJlTmoxVEV6R1RTMlNlU3RtLzNP?=
 =?utf-8?B?RUd3OHNBVExYREc1SnRMUk1RdEducTI1b082TU1wSW02Zk5vUnAzL1FwQ1FU?=
 =?utf-8?B?Z0VOUWJkekQzc2lqWTl4aVk2NHlGRnM0WTBXbmd3V0hXZE91K2FHMmJ1ZEc1?=
 =?utf-8?B?VXR2TU40bU9MbmZCZkRJVDlwdzUyN010bVdNUWg4R2JNSjBpWnZEajFYUHpD?=
 =?utf-8?B?Yzk1dCthU2xtUDlHVkxDTXdMU3QyN2ZwRU5HcVVJU0JIWW90akJXa2h1N3BT?=
 =?utf-8?B?YlpzNk5KTHBaeXdLbnFQRWkwYXNQRnYvZzNTQXlxR1VXWGFUVGtCeDBKTXFK?=
 =?utf-8?B?bTMwUStBY1lyU2tkeEduTGZXZk5oc2JzLzh4TnB5S0xhNWZTZUhSVUxkb01Q?=
 =?utf-8?B?Q2FnY1NnTllBOFJpZ3FmOEMxZkJGd2tYTXJ0SDBhYXRaQVNBaUg5M3cwSCtn?=
 =?utf-8?B?dGRIdkRBZHZSc2tnY3BYYnRZY0tvcWVZNi92U0NXSTdiVnVNYXRuWXhWWlh6?=
 =?utf-8?B?aE03TEgrWDVJSnJaMlQyZnVOOFM1M0xZNnBsYlNGdDg3NjIxVFZwclBNVTZh?=
 =?utf-8?B?clMxSG01OUZCcDRnY1g2ZlBFcGhCQWJvaG13K3BmZUVYWVpaeGhlWXpKbGFa?=
 =?utf-8?B?YklGTU9yaVJ0dXlzZmlwY0k2RUlXQjV0NHdzME5BRHhiSk5HK25jcHBlUVJF?=
 =?utf-8?B?RnpITERYM1F1dm5mSFNZUmp1cytzbERvQmljQUxNd09yWUIyQ2dlN09mbjJn?=
 =?utf-8?B?cUFLdkNTTW80YW85a2FiaUg5d05hN2p4TTJoQUtkWjMxZGdBRXppR1lLQXlU?=
 =?utf-8?B?aGEreE5Ld0t0NnlVempHZkt3VXR3ZGVVQThhTTZSSEkxaGVkdjFZOFpBK1h1?=
 =?utf-8?B?cllvRDhsajZudS9iZTE2QTJ5ZzB6Y2JadENPc1dPWUh4eWJ1US9LaGpiVkJR?=
 =?utf-8?B?SVNNdGJqM1NRWlp4SzF6dWc1NVFYUExhcW4wdXRvOXkvd0l5UGlSajFDSHVV?=
 =?utf-8?B?a3NBdHN2RHV4eUtiNm5qaE92dElqa04rdkRGRjBTYVFxR1plQ0RNRUQwZWZt?=
 =?utf-8?B?dkE1NVBMbnZJdHV3d3ljQ1JodlNVbEUrb0J3cjZ5UWFXdWhDOVVYWW9jZ0hK?=
 =?utf-8?B?QkIyUTNvVm43SytET1o0TE1sRE56Qkc5bTJCUzFFS2txaWdBRkFuVEN2S0xw?=
 =?utf-8?B?c05WK2cralBmWUdoTGFMYjUvaXBYdk0wNHNQNklIL2hFSElOZWNKdUc5Zzhv?=
 =?utf-8?B?UE5XNVdmZURyRW1iSUxrNUlPR25YZ0NtTnFEaElUR2RodE5pRVZqUEx0TFph?=
 =?utf-8?B?SUtSQm40MG85ZWx2MVpXZE41OGI1blF1VFZSSHRSWmtEWTI3bGhucmxwalRH?=
 =?utf-8?B?ZERvNGdCdmx2VlcweGZpWnhaUVRrK3dKT2JydHN0MEZkcUE1MCtsRmhCMlpj?=
 =?utf-8?B?UjdNckN2TnRLUDlBUnh6S29iYlBhcUhXN2dYbVZwSWMxUUp5TE8rMVU4a2Zp?=
 =?utf-8?Q?n1I4mZ1y0rYEeVQEHKopafg=3D?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 381f08ec-4a8d-4575-6adb-08d9c571dcb3
X-MS-Exchange-CrossTenant-AuthSource: DB9PR08MB6619.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 17:38:27.6100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m/RpxyhdT/itnTtivo2zyW/TxG62Lu+d62/u/vUCwoF241iB3Qun/SDmg7bwUtD+2gfLKpYcGS7OWpDhk8WV4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4476
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22.12.2021 20:06, Manfred Spraul wrote:
> Hi Vasily,
> 
> On 12/22/21 16:50, Vasily Averin wrote:
>> On 22.12.2021 18:31, Vasily Averin wrote:
>>> On 22.12.2021 14:45, Manfred Spraul wrote:
>>>> Hi Minghao,
>>>>
>>>> On 12/22/21 09:10, cgel.zte@gmail.com wrote:
>>>>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>>>>
>>>>> We can't call kvfree() with a spin lock held, so defer it.
>>> I'm sorry, but I do not understand why exactly we cannot use kvfree?
>>> Could you explain it in more details?
>> Got it,
>> there is cond_resched() called in __vfree() -> __vunmap()
>>
>> However I'm still not sure that in_interrupt() is used correctly here.
> 
> I see three different topics:
> 
> - is the current code violating the API? I think yes, thus there is a bug that needs to be fixed.

I'm agree. Found issue is a bug and it should be fixed ASAP,
I'm sorry for a mistake in my patch.

> - Where is __vunmap() sleeping? Would it be possible to make __vunmap() safe to be called when owning a spinlock?

I think it is possible, and we should do it to prevent similar incidents in future.
vfree() should check preempt count to detect this situation (i.e. execution under taken spinlock)
generate WARN_ON and then call __vfree_deferred() to avoid sleep.

> - should kvfree() use vfree() [i.e. unsafe when owning a spinlock] or vfree_atomic [i.e. a bit slower, but safe]

I think it's better to change vfree.

> As we did quite many s/kfree/kvfree/ changes, perhaps just switching to vfree_atomic() is the best solution.
> 
> @Andrew: What would you prefer?
> 
> In addition, if we do not use vfree_atomic(): Then I would propose to copy the might_sleep_if() from vfree() into kvfree()
I think it does not help, as far as I understand we are in task context, just under taken spinlock.

Thank you,
	vasily Averin