Date:   Wed, 22 Dec 2021 13:50:15 -0400
From:   Rob Herring <robh@kernel.org>
To:     Tinghan Shen <tinghan.shen@mediatek.com>
Cc:     broonie@kernel.org, sean.wang@mediatek.com,
        linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
        matthias.bgg@gmail.com, devicetree@vger.kernel.org,
        bgolaszewski@baylibre.com, linux-mediatek@lists.infradead.org,
        bayi.cheng@mediatek.com, linux-arm-kernel@lists.infradead.org,
        linus.walleij@linaro.org, gch981213@gmail.com,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        robh+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/4] dt-bindings: pinctrl: mt8195: add wrapping node
 of pin configurations
Message-ID: <YcNlVzSZAWCM9eKO@robh.at.kernel.org>
References: <20211220121825.6446-1-tinghan.shen@mediatek.com>
 <20211220121825.6446-4-tinghan.shen@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211220121825.6446-4-tinghan.shen@mediatek.com>
Precedence: bulk

On Mon, 20 Dec 2021 20:18:24 +0800, Tinghan Shen wrote:
> On mt8195, the pinctrl node has pinctrl groups to group pin
> configurations by users' need. In each pinctrl group, it has
> subnode(s) to list pins needed and pin configurations. By supporting
> multiple subnodes, we can configure different pin characteristics
> (driving/pull-up/pull-down/etc.) in a pinctrl group.
> 
> Update pinctrl-mt8195.yaml to add subnode in pinctrl groups and an
> example to illustrate the usage.
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>  .../bindings/pinctrl/pinctrl-mt8195.yaml      | 338 ++++++++++--------
>  1 file changed, 188 insertions(+), 150 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>