Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D886C433EF for ; Wed, 22 Dec 2021 19:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345161AbhLVTU6 (ORCPT ); Wed, 22 Dec 2021 14:20:58 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:45674 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345143AbhLVTU5 (ORCPT ); Wed, 22 Dec 2021 14:20:57 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 178091F38B; Wed, 22 Dec 2021 19:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1640200856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1zHmlER6FzSVw4dWcjyK+b62FBYuP29ydpBgw6lGwcc=; b=BDmKP5TB24o/km0CgXB1JbI7PHUYXjpRu8a7WbDYJjGzq6thoQjAuQ7M6zbIg9gqRYq7Sq 7Pyvmrb5ZTZIxNdGbMGTf3+IwOsBwK7HBPiGQ2xPNEyPP9zC8ozhHsEDR0SxsCgizWn1iL sApZKjWpm1jy+LSqq6YwWluVW8Gcq/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1640200856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1zHmlER6FzSVw4dWcjyK+b62FBYuP29ydpBgw6lGwcc=; b=nLPUempEuzqrbaQQ83UFL2r7tiUY9BmSZwkcj0OGuP5ciBODrmBKJx94ltU2v+Lj33/Rpm pTPdDtHO36KyFZBw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 07FDDA3B83; Wed, 22 Dec 2021 19:20:56 +0000 (UTC) Date: Wed, 22 Dec 2021 20:20:56 +0100 Message-ID: From: Takashi Iwai To: Werner Sembach Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Fix quirk for Clevo NJ51CU In-Reply-To: <20211215191646.844644-1-wse@tuxedocomputers.com> References: <20211215191646.844644-1-wse@tuxedocomputers.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Dec 2021 20:16:46 +0100, Werner Sembach wrote: > > The Clevo NJ51CU comes either with the ALC293 or the ALC256 codec, but uses > the 0x8686 subproduct id in both cases. The ALC256 codec needs a different > quirk for the headset microphone working and and edditional quirk for sound > working after suspend and resume. > > When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of > 0x0020 on the ALC256 codec. Setting the value manually makes the sound > work again. This patch does this automatically. > > Signed-off-by: Werner Sembach > Fixes: b5acfe152abaa ("ALSA: hda/realtek: Add some Clove SSID in the ALC293(ALC1220)") > Cc: Thanks, applied now with a minor coding style fix. Takashi