Subject: Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP
 support
To:     Jon Hunter <jonathanh@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Viresh Kumar <vireshk@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Lee Jones <lee.jones@linaro.org>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Nishanth Menon <nm@ti.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Michael Turquette <mturquette@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-clk@vger.kernel.org, David Heidelberg <david@ixit.cz>
References: <20211130232347.950-1-digetx@gmail.com>
 <20211130232347.950-9-digetx@gmail.com>
 <21212ddb-205f-71d6-0199-d75768eaf32c@nvidia.com>
 <41edc53b-5ed1-d524-2546-c3d1ee6cdea4@gmail.com>
 <6652ac84-36f5-0e43-65fa-04786f384f21@nvidia.com>
 <56dce9c7-397d-75b0-b5b8-18ce1084e72b@nvidia.com>
 <6dbc8205-5669-8b08-16b8-fe5e1acdd06f@gmail.com>
 <796eb3f7-80e2-bc55-fd52-43e76220f8c2@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <40983f6e-92ee-40d4-861f-06faea0113fc@gmail.com>
Date:   Wed, 22 Dec 2021 22:31:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <796eb3f7-80e2-bc55-fd52-43e76220f8c2@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

22.12.2021 22:30, Jon Hunter пишет:
> 
> On 22/12/2021 19:01, Dmitry Osipenko wrote:
> 
> ...
> 
>> diff --git a/drivers/gpu/host1x/syncpt.c b/drivers/gpu/host1x/syncpt.c
>> index e08e331e46ae..8194826c9ce3 100644
>> --- a/drivers/gpu/host1x/syncpt.c
>> +++ b/drivers/gpu/host1x/syncpt.c
>> @@ -137,6 +137,15 @@ void host1x_syncpt_restore(struct host1x *host)
>>       struct host1x_syncpt *sp_base = host->syncpt;
>>       unsigned int i;
>>
>> +    for (i = 0; i < host->info->nb_pts; i++) {
>> +        /*
>> +         * Unassign syncpt from channels for purposes of Tegra186
>> +         * syncpoint protection. This prevents any channel from
>> +         * accessing it until it is reassigned.
>> +         */
>> +        host1x_hw_syncpt_assign_to_channel(host, sp_base + i, NULL);
>> +    }
>> +
>>       for (i = 0; i < host1x_syncpt_nb_pts(host); i++)
>>           host1x_hw_syncpt_restore(host, sp_base + i);
>>
>> @@ -352,13 +361,6 @@ int host1x_syncpt_init(struct host1x *host)
>>       for (i = 0; i < host->info->nb_pts; i++) {
>>           syncpt[i].id = i;
>>           syncpt[i].host = host;
>> -
>> -        /*
>> -         * Unassign syncpt from channels for purposes of Tegra186
>> -         * syncpoint protection. This prevents any channel from
>> -         * accessing it until it is reassigned.
>> -         */
>> -        host1x_hw_syncpt_assign_to_channel(host, &syncpt[i], NULL);
>>       }
>>
>>       for (i = 0; i < host->info->nb_bases; i++)
>>
> 
> 
> Thanks! This fixed it!

I'll prepare proper patch with yours t-b, thank you.