IronPort-SDR: h6pnkbaekqyztOOpKDko8cYeZBKO/R+My30sifgeKS2qWt57KwgfgIsU8O73PlducTOUxW+Z/j
 T6/k5XiJrtY9UgdqZKyOwAHeLL4OPV09kCDZWxdIuRr9kY1UDOJw45sXjy+kOs8TE3EkDEBKmK
 iEw9Xnr4dlN8oJB04N4OPd2eRcFl7lefaII7nbut2GICtfvFBEFi3I2tojma9QfenFT1Vz3eCY
 iCoRPkuc2V+ZGE6r+8/ZCxB91tAgZ+NjvpHVorcv3YxjV8nS8q6w6C20EZl6WGdGcyFQ/L3Yn3
 nAUz/wdsTH4cMn57/Q8Y2T+D
IronPort-SDR: Yc9TfOGZdmtVYXrfG8fBGweR9e+zg9vK2rSdxUXZN3+0py2Vf8U266VJJ8g3S3eU+zhxHE8IS1
 OMixxb7kTyQIiRLZ++dTvS7klR5CY3kiHEMjQwQF92gKxf13bTsPHVn7QvXIxExqRCgCif0PG2
 ZX4h7l0EZWbL7W4w1tVG2WgFvbWSMVVFQQWHzVTlKH4fKYXcvZ1seRPDJ8M1HcqD4CeIoT/ovK
 ORHf2XWeByiNQKP0EXB0pa1YBQxGqJ1ny5/jagq9MDIt92zo6kF4c1uNoSDx4NkYPW4xucEg7h
 0XU=
WDCIronportException: Internal
Message-ID: <d851cdc5-78c6-ff35-979f-7aec71f3cb9b@opensource.wdc.com>
Date:   Thu, 23 Dec 2021 09:35:23 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/4] ata: pata_platform: make use of
 platform_get_mem_or_io()
Content-Language: en-US
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>, linux-ide@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Prabhakar <prabhakar.csengg@gmail.com>
References: <20211221162614.25308-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20211221162614.25308-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20211221162614.25308-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/22/21 01:26, Lad Prabhakar wrote:
> Make use of platform_get_mem_or_io() to simplify the code.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1-->v2
> * No change
> ---
>  drivers/ata/pata_platform.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
> index 028329428b75..cb3134bf88eb 100644
> --- a/drivers/ata/pata_platform.c
> +++ b/drivers/ata/pata_platform.c
> @@ -198,22 +198,16 @@ static int pata_platform_probe(struct platform_device *pdev)
>  	/*
>  	 * Get the I/O base first
>  	 */
> -	io_res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> -	if (io_res == NULL) {
> -		io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		if (unlikely(io_res == NULL))
> -			return -EINVAL;
> -	}
> +	io_res = platform_get_mem_or_io(pdev, 0);
> +	if (unlikely(!io_res))

This is not the hot path, so I do not think that the unlikely() is
necessary here.

> +		return -EINVAL;
>  
>  	/*
>  	 * Then the CTL base
>  	 */
> -	ctl_res = platform_get_resource(pdev, IORESOURCE_IO, 1);
> -	if (ctl_res == NULL) {
> -		ctl_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -		if (unlikely(ctl_res == NULL))
> -			return -EINVAL;
> -	}
> +	ctl_res = platform_get_mem_or_io(pdev, 1);
> +	if (unlikely(!ctl_res))

Same comment here.

> +		return -EINVAL;
>  
>  	/*
>  	 * And the IRQ


-- 
Damien Le Moal
Western Digital Research