IronPort-SDR: 9ZzOGI3AnrRbD5sd2mLKVKC1kQcNnIYGlNUhC5As8F+f8xYGntKJpzJt+efyIVUhDIKDEmnzvT
 9L//RYuzQC9BZxxS4JTAa+IHKGrJcTY3QaZt5xHXmYgjHJxFEL5lMlyF09vseFWunpuVSVR83y
 ZjJUpCqCHXKsSqqnSKM1efYIdmqUpmpMvoLpVueq+eOmmWtS7mYvSoR6WfH1NLdxP5kPofu9ZU
 gIYQH8p12r7/jGBkmApaqZPM6Mh5rkMEUJ+0CRoH8R9qEW/+rwkyvwElv1T3RsvLy+c8SK7qCC
 eT7d6ZSrwY4Z6QWNBSoB2ppg
IronPort-SDR: VQuNruLQ/hip1Ev3CbENz0/Ru+J0QZ0XKKafBvmSZ2TD1e8FSG59mxpy5GVvhbEBIt+di0VtpL
 ea5dT6e8JTB+SUHn1G24IepT4XM059lKRCy5o+S42wwO5WCpE/hioTEZFN8SV+TqYEBGOj0JhD
 msrfqm/e6InuyIa5GXnELZOIxn0xLqAEyxXsDGQ9UgmMVMJgiSTJWj5gEI1kOYpKB5befVqe00
 FTsD4nOmTVPKtzO+OtdaYe7Avo53by8prULhh59XHbrEZ6q8IL3N3Wq3wiNxJbkgxaOKUNpvL/
 UU8=
WDCIronportException: Internal
Message-ID: <dd6e6054-3d7e-b43a-0386-71323c49ab27@opensource.wdc.com>
Date:   Thu, 23 Dec 2021 09:41:54 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] ata: libahci_platform: Remove abundant check
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, hdegoede@redhat.com,
        axboe@kernel.dk, p.zabel@pengutronix.de
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/22/21 16:24, Jiasheng Jiang wrote:
> It can be found that platform_get_irq() returns nagative code but not
> null when fails.
> The comment of the platform_get_irq clearly shows that.
> Therefore it should be better to remove the useless check.

Nope, platform_get_irq() can actually return 0 (the comment for that
function is wrong). So testing for !irq is valid and must be kept.

> 
> Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/ata/libahci_platform.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index b2f552088291..5ec68f138c28 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -587,8 +587,6 @@ int ahci_platform_init_host(struct platform_device *pdev,
>  			dev_err(dev, "no irq\n");
>  		return irq;
>  	}
> -	if (!irq)
> -		return -EINVAL;
>  
>  	hpriv->irq = irq;
>  


-- 
Damien Le Moal
Western Digital Research