IronPort-SDR: xxt2eKoP0Qj48hAXHa9gYf2bw8FsuZMG49k664gr6Ds/M/IzfW4G2jiXzGITHPZSi/BTATON1R
 V2uJxOfjgCkiyoWajK/a3eUCmkzz928lUsfE0xkehuScO4Ua6uHKdFkwV5nzRlNIp2e0sVvctN
 faMebM/KwWbd+eV4X28S6t0qJl11ibD5vnK56VvUDxH+/vvgAdz+pBbWctL9ejaLGMcuYVXWhr
 tPn/lEqQp65pJ5zjX1N/Srbih0xMqxdfH8tY8X9lYzKCtxQuxPd+jnwf2PPrRTi6l93caMsBpP
 742+jZu5mTQP6g92XEkkAiTv
IronPort-SDR: R/ujB4SdsbDgh8FoaFb46M1ZNktuq9MvJ604FaPWSWCA8LM7Tvh1bzS5SSg1I8MpRD2y93cEdy
 XtEThoDLs/Pfq8Qt/szQv5xMVDE1IKGrcpTA5sbA3le/Jv6DSu0bo1FVdP0ZkNmyivdRIH+Jyj
 os/PzeZkm1qFubuZVimBBjVy0VJa9COBin2kukggjeWaJcPSYURMNvOGSh1zXYAEiM9ps4WFuN
 BncuSL0U8ZdnDHiYhcgeA8AdFK/kAPmcjtfWtT1Ff27614Dg7j7ZlEMyTj90gv1XuapA9GB6lI
 Y+0=
WDCIronportException: Internal
Message-ID: <c31cd71c-901b-27b5-8054-fcf576533590@opensource.wdc.com>
Date:   Thu, 23 Dec 2021 09:44:39 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] ata: libahci_platform: Remove abundant check
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, hdegoede@redhat.com,
        axboe@kernel.dk, p.zabel@pengutronix.de
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/22/21 16:24, Jiasheng Jiang wrote:
> It can be found that platform_get_irq() returns nagative code but not
> null when fails.
> The comment of the platform_get_irq clearly shows that.
> Therefore it should be better to remove the useless check.
> 
> Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Another note: please use scripts/get_maintainer.pl to see to whom you
should address patches. This one was not addressed to me.

> ---
>  drivers/ata/libahci_platform.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index b2f552088291..5ec68f138c28 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -587,8 +587,6 @@ int ahci_platform_init_host(struct platform_device *pdev,
>  			dev_err(dev, "no irq\n");
>  		return irq;
>  	}
> -	if (!irq)
> -		return -EINVAL;
>  
>  	hpriv->irq = irq;
>  


-- 
Damien Le Moal
Western Digital Research