From:   "Huang, Ying" <ying.huang@intel.com>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     <sj@kernel.org>, <akpm@linux-foundation.org>,
        <dave.hansen@linux.intel.com>, <ziy@nvidia.com>,
        <shy828301@gmail.com>, <zhongjiang-ali@linux.alibaba.com>,
        <xlpang@linux.alibaba.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Add a new scheme to support demotion on tiered
 memory system
References: <cover.1640171137.git.baolin.wang@linux.alibaba.com>
Date:   Thu, 23 Dec 2021 09:07:05 +0800
In-Reply-To: <cover.1640171137.git.baolin.wang@linux.alibaba.com> (Baolin
        Wang's message of "Wed, 22 Dec 2021 19:14:39 +0800")
Message-ID: <87a6gsceo6.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Precedence: bulk

Baolin Wang <baolin.wang@linux.alibaba.com> writes:

> Hi,
>
> Now on tiered memory system with different memory types, the reclaim path in
> shrink_page_list() already support demoting pages to slow memory node instead
> of discarding the pages. However, at that time the fast memory node memory
> wartermark is already tense, which will increase the memory allocation latency
> during page demotion. So a new method from user space demoting cold pages
> proactively will be more helpful.
>
> We can rely on the DAMON in user space to help to monitor the cold memory on
> fast memory node, and demote the cold pages to slow memory node proactively to
> keep the fast memory node in a healthy state.
>
> This patch set introduces a new scheme named DAMOS_DEMOTE to support this feature,
> and works well from my testing. Any comments are welcome. Thanks.

As a performance optimization patch, it's better to provide some test
results.

Another question is why we shouldn't do this in user space?  With DAMON,
it's possible to export cold memory regions information to the user
space, then we can use move_pages() to migrate them from DRAM to PMEM.
What's the problem of that?

Best Regards,
Huang, Ying

> Changes from v1:
>  - Reuse the demote_page_list().
>  - Fix some comments style issues.
>  - Move the DAMOS_DEMOTE definition to the correct place.
>  - Rename some function name.
>  - Change to return void type for damos_isolate_page().
>  - Remove unnecessary PAGE_ALIGN() in damos_demote().
>  - Fix the return value for damos_demote().
>
> Baolin Wang (2):
>   mm: Export the demote_page_list() function
>   mm/damon: Add a new scheme to support demotion on tiered memory system
>
>  include/linux/damon.h |   3 ++
>  mm/damon/dbgfs.c      |   1 +
>  mm/damon/vaddr.c      | 147 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  mm/internal.h         |   2 +
>  mm/vmscan.c           |   4 +-
>  5 files changed, 155 insertions(+), 2 deletions(-)