Date:   Wed, 22 Dec 2021 18:02:55 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] memcg: add per-memcg vmalloc stat
Message-ID: <YcPYz4N0sXEVFaJA@carbon.dhcp.thefacebook.com>
References: <20211222052457.1960701-1-shakeelb@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211222052457.1960701-1-shakeelb@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sLDQat7Jvi4PIH8S+e4iOti4TGjVqur17Rwx0UbgEf8J4XZZkKTXQbWs6OhB?=
 =?us-ascii?Q?cBgeSuM3vAZWrOb80alPap+q999xCTR/N5ZFKEUENJOsUm8Y03tz05eqUq8j?=
 =?us-ascii?Q?4P+BTLjhdOTQrHh+VbvVvMLOqHFQEK8cLAWuxirbyCogQbkT4TggXDWpyhdE?=
 =?us-ascii?Q?bqCCJgqv242Vj2x115yhpIwhXJg3BdlXxECc2g9uiEHku+X2ZNNkZR2AkMoO?=
 =?us-ascii?Q?ci1RVkrhZTxi5jXLTa+Hg54ETfQQFBgzjWmd6CBj33Cm2XFvA4e2LV5ejgVM?=
 =?us-ascii?Q?QhbrH7ranm5vBw5Z0ayqlNYbWPsa9dyvT4BffT8PE8T4yaPPEV4dOg3gGcOF?=
 =?us-ascii?Q?6BMunOlmAxTMwsWhk5PJ3ydJqwbeCV6ttUDf15xDnfKdqQWtuilnz+zH0bWo?=
 =?us-ascii?Q?m+2lXud9JV3D/DVAtuov0qqoS61ME7pUe2wkiYRgaxSdKOr+vQRMvaRWa379?=
 =?us-ascii?Q?Kes1/1TsQWmQ+1uNdQk58eUySoZaVkW0G8Rn0iM2kjSE6ExXz+ecHkYXnbry?=
 =?us-ascii?Q?g8txH27v6zzmuj9iQncc48ApVXB4ipCS0ZeNyQJ04y0VH5Ov2t/3ICnyuhvt?=
 =?us-ascii?Q?nNY+UIR/u4mAvq0ryey3kWlhAstHSQhysDdC35pRxswSLTyqlkSv2fblA8bC?=
 =?us-ascii?Q?b8qdLmGWp43/gT/WO9NH8IUTJFNp80JhJhVklGY7DNtxfCdfmNP/lDH2gj6x?=
 =?us-ascii?Q?vMCJR5tUPccZ+EPZnWbH7+FRdbyG36dTyqZ6eB81SyKjnyYmDJ9lrODi0jDW?=
 =?us-ascii?Q?/lcFYQ+HfwFMYOzQA3TKFPMRs0wm7gMxaZ5tRErE868VH4d6eIS9HdfxZ7av?=
 =?us-ascii?Q?bw+zhSbXwWC8oGS4wjR5RErk4g7z4smQBx/SQsPLT/UKxmBtqfnhNrML9xah?=
 =?us-ascii?Q?cXp3itiupWXxh7V2UJK24b3KmqbseCko0AJTwhlQ1qgmFqvT6yG+mxZOYA/x?=
 =?us-ascii?Q?kO9N84h1Kj75C9wiZzkwql185XDrp5qJE4nJujOpvI4pXbI0yd8luAZOTep4?=
 =?us-ascii?Q?6PZefa2L7HZIIlklit7f4CaMxzk8jPdhmCgRQR+NDVcDsOw7zSqTNGjcCo3K?=
 =?us-ascii?Q?6YzHDDRyCzFxoau7MxEO7+xwLuBaJ1MtyJ6HzGrXe1qpbrs1lWyXk8HOnAfM?=
 =?us-ascii?Q?ASA77ssf/63dMKp0cHVIPWKEMIi3ZPFmKaEVib6bqfrb6oXTGamo6ejB9NcO?=
 =?us-ascii?Q?vYSTNWquLNted5ZNBv/aDXR9RG5p5ZQW/onVYv6wFwurNKKnFszWkzjf0VMm?=
 =?us-ascii?Q?jLbrLHOuQcINIFdsWZ0gaoAeCFVKJVCrJENPIlsoozpJ7bz2FvdJ1C2MPEHc?=
 =?us-ascii?Q?yNLGWoAHO6JbQyBUOqUY/RJHZ7UkZSNbifY7Js0aGSyAoWTfX5VCWl14DqWD?=
 =?us-ascii?Q?HALHBVjFqm3qMltuJX2Cggj54DGE7DPq717jr5etp/pIwfLFEQvgT7oodwVK?=
 =?us-ascii?Q?ozT3xg16cT5c3irV6NCi4pVFAgZm+OmbVk6Dp2Qxo+eeIiuPE75rMrh7OhLf?=
 =?us-ascii?Q?OcXqkIAwyKgmM5IajYeF237gR0XTW51YfoWFIKMp8CMtYvt2/JQIasRehfPR?=
 =?us-ascii?Q?J2tJh3Q6B/581eIwYEIXV3S5NIfrV8yAts6ydj/9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cf9c4231-5817-4f33-4f3f-08d9c5b857b2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2021 02:02:58.7781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4RhUX/2gADZh7RlVCp9lKYAED+P98/ICYKQMqOvhK34kQYS3EuNxaDh7mhyG5EUK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2599
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: -YoweW0LxYsVG9ybcLc_7-WsrF4d70iz
X-Proofpoint-GUID: -YoweW0LxYsVG9ybcLc_7-WsrF4d70iz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_09,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 lowpriorityscore=0
 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxscore=0
 suspectscore=0 adultscore=0 mlxlogscore=939 bulkscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230008
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 21, 2021 at 09:24:57PM -0800, Shakeel Butt wrote:
> The kvmalloc* allocation functions can fallback to vmalloc allocations
> and more often on long running machines. In addition the kernel does
> have __GFP_ACCOUNT kvmalloc* calls. So, often on long running machines,
> the memory.stat does not tell the complete picture which type of memory
> is charged to the memcg. So add a per-memcg vmalloc stat.
> 
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> 
> ---
> Changelog since v1:
> - page_memcg() within rcu lock as suggested by Muchun.
> 
>  Documentation/admin-guide/cgroup-v2.rst |  3 +++
>  include/linux/memcontrol.h              | 21 +++++++++++++++++++++
>  mm/memcontrol.c                         |  1 +
>  mm/vmalloc.c                            |  5 +++++
>  4 files changed, 30 insertions(+)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 82c8dc91b2be..5aa368d165da 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1314,6 +1314,9 @@ PAGE_SIZE multiple when read back.
>  	  sock (npn)
>  		Amount of memory used in network transmission buffers
>  
> +	  vmalloc (npn)
> +		Amount of memory used for vmap backed memory.
> +

It's a bid sad that this counter will partially intersect with others
(e.g. percpu and stack), but I don't see how it can be easily fixed.

But I agree that the counter is useful and worth adding.

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!