Date:   Thu, 23 Dec 2021 12:18:12 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_exar: derive nr_ports from ID for
 Acces I/O cards
Message-ID: <YcRM5NN/rEsU7PEa@smile.fi.intel.com>
References: <20211222194413.75069-1-andriy.shevchenko@linux.intel.com>
 <6c60d8c1-ff64-8e93-79f1-1a3dd352d7a2@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6c60d8c1-ff64-8e93-79f1-1a3dd352d7a2@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Dec 23, 2021 at 12:05:11PM +0200, Ilpo J?rvinen wrote:
> On Wed, 22 Dec 2021, Andy Shevchenko wrote:

...

> > -	nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;
> > +	if (pcidev->vendor == PCI_VENDOR_ID_ACCESSIO)
> > +		nr = BIT(((pcidev->device & 0x38) >> 3) - 1);
> 
> Shouldn't this be nr_ports = ...

Yeah, sorry for that. By some reason I have no such config option enabled and
my builds haven't failed.

-- 
With Best Regards,
Andy Shevchenko