MIME-Version: 1.0
References: <20211223123232.1353785-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20211223123232.1353785-1-jiasheng@iscas.ac.cn>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 23 Dec 2021 14:37:06 +0200
Message-ID: <CAHp75VcuXAiLGy7p+2A1839x=9-L=E71xkTaRncx0-Jf2Fh_mg@mail.gmail.com>
Subject: Re: [PATCH v2] drivers: net: smc911x: Check for error irq
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 23, 2021 at 2:33 PM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
> On Thursday, December 23, 2021, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > Do other way around.
> > ret = ...
> > if (ret < 0)
> >   ...
> > irq = ret;
>
> This version I correct the patch by using error variable, too.
> And the commit message is as follow.
>
> Because platform_get_irq() could fail and return error irq.
> Therefore, it might be better to check it in order to avoid the use of
> error irq.

Fix commit message and send v3.

-- 
With Best Regards,
Andy Shevchenko