Date:   Thu, 23 Dec 2021 13:57:54 +0100
From:   Jan Kara <jack@suse.cz>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc:     corbet@lwn.net, Jan Kara <jack@suse.cz>,
        "Darrick J. Wong" <djwong@kernel.org>, axboe@kernel.dk,
        "zhangyi (F)" <yi.zhang@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-doc@vger.kernel.org, linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] doc: fs: remove bdev_try_to_free_page related doc
Message-ID: <20211223125754.GC19129@quack2.suse.cz>
References: <c45e6351-b0f8-3410-787e-02c6aeb3efe6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c45e6351-b0f8-3410-787e-02c6aeb3efe6@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu 23-12-21 11:51:00, Zhiqiang Liu wrote:
> 
> In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
> bdev_try_to_free_page has been removed.
> 
> We should remove its doc.
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

Indeed. Thanks. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/filesystems/locking.rst | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> index d36fe79167b3..3f9b1497ebb8 100644
> --- a/Documentation/filesystems/locking.rst
> +++ b/Documentation/filesystems/locking.rst
> @@ -169,7 +169,6 @@ prototypes::
>  	int (*show_options)(struct seq_file *, struct dentry *);
>  	ssize_t (*quota_read)(struct super_block *, int, char *, size_t, loff_t);
>  	ssize_t (*quota_write)(struct super_block *, int, const char *, size_t, loff_t);
> -	int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
> 
>  locking rules:
>  	All may block [not true, see below]
> @@ -194,7 +193,6 @@ umount_begin:		no
>  show_options:		no		(namespace_sem)
>  quota_read:		no		(see below)
>  quota_write:		no		(see below)
> -bdev_try_to_free_page:	no		(see below)
>  ======================	============	========================
> 
>  ->statfs() has s_umount (shared) when called by ustat(2) (native or
> @@ -210,9 +208,6 @@ dqio_sem) (unless an admin really wants to screw up something and
>  writes to quota files with quotas on). For other details about locking
>  see also dquot_operations section.
> 
> -->bdev_try_to_free_page is called from the ->releasepage handler of
> -the block device inode.  See there for more details.
> -
>  file_system_type
>  ================
> 
> -- 
> 2.23.0
> 
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR