Message-ID: <beb50d46-e3ce-92fc-98b8-ea8c8222bd04@oracle.com>
Date:   Thu, 23 Dec 2021 09:00:20 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v4 1/3] mm_zone: add function to check if managed dma zone
 exists
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de,
        cl@linux.com, kexec@lists.infradead.org, 42.hyeyoo@gmail.com,
        penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com,
        x86@kernel.org, bp@alien8.de,
        John Donnelly <john.p.donnelly@oracle.com>
References: <20211223094435.248523-1-bhe@redhat.com>
 <20211223094435.248523-2-bhe@redhat.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211223094435.248523-2-bhe@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGdSZ1ZwVVRyZytUTDMvYS9lN2sySkxUUWV6UDlZQ29veGVOUHFnVUgxL2xt?=
 =?utf-8?B?T3Q3WEtUZTlhMkNvaVJSaTV0ajFSWVhRZVZkT3h1aWxKV2lwTW1UVkNFMkRw?=
 =?utf-8?B?ZXh5WFovVUV0MTMvUHpUQ3hTWjlHMEFjZTBBS2dpdis2a0dCUCt1L0g2akdY?=
 =?utf-8?B?Ykt2d0E1Zm02YXErZW90ZEJFZHNuTW5PUjNrZm9PdUxTT3RQT2dVUkhOWVQ0?=
 =?utf-8?B?R0p6NHJqVVhDNWdVN0laUDU1RERxSGQvR3l6Q0Q1NWZqOG1RMG1LY1A3VEJD?=
 =?utf-8?B?M3lNSFIyVjI2TUY4MWM0aG1CRmxDWm1rQTdiZXFvdEVndXdvTmtUck5NRmQy?=
 =?utf-8?B?WTVLQURIeFcyTGo2TGVzQlNmRGdTYjVlZnBNV25EVGs0OTI5SWNMWXhpZWdp?=
 =?utf-8?B?VUdOM0dTMUpUTGNNYnR6UzVDUE5iR1Z4YzlYbXovM253UlBHUEhFRjc1WTg3?=
 =?utf-8?B?Y2tSaEZ2bkJtUzFQL2xMeUg2MCs2S1pJTGZlNlNsSnpzUnV6aTNvaVRMUmNl?=
 =?utf-8?B?MVdlaEdRQWNjZzNhcTVwY25XcFYzNlY0WjNkNkNPWGdkemJ1b1BZQ2FRSHNz?=
 =?utf-8?B?YU1mU2YvYS9lTkZEeTBLRUJGNzhhVGNLTUNGcGJFS1NrZ1VjbzFXMTIzWnQv?=
 =?utf-8?B?OXZwY2ZjcHoxNUVzb1kzUzRGbmp3TXhTdU9yb0lTcmRic1ZkSkJsSWtxTTlZ?=
 =?utf-8?B?SFY4RnRrY2hGaDFIOVdyQXVvczBIa0FCaEF5MS9VaWY0VzV6UU1MZ21Nai9q?=
 =?utf-8?B?dCtJSUo5UjY0OU5qbnVIYWI3NzUzVklGUXlGL1VPVnljYnEvOEEyYTFxbUJT?=
 =?utf-8?B?SFZLei90Qnh4WEdnN3RTZFQyK1IrZi9RVEV5VmNTczk4UWtKRVNWcFgzYUlq?=
 =?utf-8?B?b3pSTzVhVkM0YlRQLzArMUh4QXpONzV5RkR1WGJpeFhCZWV0WFZ0K2ZCWjJw?=
 =?utf-8?B?RUpvcTUrNkg3NjhiQlFqQ0NmYnJBK0IxbWpJUWRETU5uajVwczBaaG5VamNP?=
 =?utf-8?B?TWpoNHJlZHBIb3ArWmpVM2FKYzE4K3MrbmYrNTJMeDlsSHFrNHpjWTVmZTJx?=
 =?utf-8?B?VHlRazJDVXJKeklIMm11ak5vOEJSaGFzUXBnTHRZWCtrWHdUdkplWFB4Zkx1?=
 =?utf-8?B?cDY4VEhqdXR0QzJja1hqSFFJS1dKRU9CSkdIQndidkF6KzFTQWY1QmNGZ2Ny?=
 =?utf-8?B?TjByR2pNSmxNL3BDYVpTSFJkUElkQWErM3U4WWsyd2J1RjZSc2JZY3crcStm?=
 =?utf-8?B?cnhYVTIwT0ZtVmE0Z3NwanpBT0pRdFZUem1hYkhxekZlZFpya3ljbkxkcXpz?=
 =?utf-8?B?SHltdVJJSkd5NjhQOFRzUjVDRStNck01cVFheHZ2MHArL2RIaFR3VUQxNHB2?=
 =?utf-8?B?TksxNWl1cWNMbGJFdTZtWEdHS1o3TjFMZThvYnVkSUdaZ2RQKzFJem1YazEr?=
 =?utf-8?B?UlFqdlJNeHdvcGhhc0R3djdPYkZjbnREamhyQ2trTGJXVGtBL0hRMmd0WWFB?=
 =?utf-8?B?VDRCYmpUaDVNWmczaitwT2pxTi9VSnJvQm9ZVjZsdGtEYTI5TnFZcStMVERX?=
 =?utf-8?B?T0owSTFUa2l2UEtLWmQyWWZNRmtLWmY1eDlUd2MvMVRnV0dLUlJJWUg0c1Ju?=
 =?utf-8?B?U3kyQnhtdnpUZU1YQzNjZTBIUW1QK3lkTGZwaUNYZFBoY2FjRHIxQjVXMDJC?=
 =?utf-8?B?YXozM2xmMDI2OVhVemNMQWhHVEJWUk9aZXJZamdYMzByVTg2bzg0ZkFscVU5?=
 =?utf-8?B?cnlvVUlqeW1wVVZKQnVmaTV4ZDZ3b0JybWUwcDA3djFYOE9IM0NMUlo4dEcw?=
 =?utf-8?B?eURuQnR4YkQzLyt0Ymk0dERaWUoyWnZxaGZZSHgrSnRWMEVXNEdRc0QrUFU3?=
 =?utf-8?B?L2RsNjAwUS84a2tuaGZ4RkY5ci9MTEdrNkFQenNMUWh0eHhtL0NEQm9JRjJU?=
 =?utf-8?B?V01oaEgyVSswY3Z5K2YrbnpCM0hlQUVXTVBkREVUUXlJbzNlQ09QSmJTcTFi?=
 =?utf-8?B?WGwyd2ZmSEphV3RQTis1VXFqWDdhTWtmQjJJK1E5MjdSU3BOTHpnbGN3OXVX?=
 =?utf-8?B?di9peHpHR3p3Q1VaLzhLTVlxdXJZUlo4NzVRMll1akFxS3RBTFlBTUxsellP?=
 =?utf-8?B?aW11YkhWZ0p0VGEwTUNUZWg0dlk3Z0NnR1ZGOStCdkk0K0F5aW1zNVVOQ0cy?=
 =?utf-8?B?YjdxS3UwN2p0UkgyWGFMK3BHSTY1YWxtYzI3MTV0ZVgvcHIzVm9oZUllOUNh?=
 =?utf-8?B?Uk5yRDB3VVM1K2JRdjNjd0RkRmNRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98cd9e20-7766-491f-4a93-08d9c624f720
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2021 15:00:31.8264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xQfTWmQhpk2FxNYHSrEN1egCGi4wTXfsGEvjg7tjdja8xlFc4mK3PLUENJhl5lT0+G2tSbfK4qw2WBTiDBfTS0W6ur8XpZYTq62dz1qJGyE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5458
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10206 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230081
X-Proofpoint-GUID: DVByPfXiCysPSGh9AGJp5J4I-J3TIbK2
X-Proofpoint-ORIG-GUID: DVByPfXiCysPSGh9AGJp5J4I-J3TIbK2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/23/21 3:44 AM, Baoquan He wrote:
> In some places of the current kernel, it assumes that dma zone must have
> managed pages if CONFIG_ZONE_DMA is enabled. While this is not always true.
> E.g in kdump kernel of x86_64, only low 1M is presented and locked down
> at very early stage of boot, so that there's no managed pages at all in
> DMA zone. This exception will always cause page allocation failure if page
> is requested from DMA zone.
> 
> Here add function has_managed_dma() and the relevant helper functions to
> check if there's DMA zone with managed pages. It will be used in later
> patches.
> 
> Fixes: 6f599d84231f ("x86/kdump: Always reserve the low 1M when the crashkernel option is specified")
> Cc: stable@vger.kernel.org
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: John Donnelly  <john.p.donnelly@oracle.com>

> ---
>   include/linux/mmzone.h |  9 +++++++++
>   mm/page_alloc.c        | 15 +++++++++++++++
>   2 files changed, 24 insertions(+)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 58e744b78c2c..6e1b726e9adf 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1046,6 +1046,15 @@ static inline int is_highmem_idx(enum zone_type idx)
>   #endif
>   }
>   
> +#ifdef CONFIG_ZONE_DMA
> +bool has_managed_dma(void);
> +#else
> +static inline bool has_managed_dma(void)
> +{
> +	return false;
> +}
> +#endif
> +
>   /**
>    * is_highmem - helper function to quickly check if a struct zone is a
>    *              highmem zone or not.  This is an attempt to keep references
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index c5952749ad40..7c7a0b5de2ff 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -9460,3 +9460,18 @@ bool take_page_off_buddy(struct page *page)
>   	return ret;
>   }
>   #endif
> +
> +#ifdef CONFIG_ZONE_DMA
> +bool has_managed_dma(void)
> +{
> +	struct pglist_data *pgdat;
> +
> +	for_each_online_pgdat(pgdat) {
> +		struct zone *zone = &pgdat->node_zones[ZONE_DMA];
> +
> +		if (managed_zone(zone))
> +			return true;
> +	}
> +	return false;
> +}
> +#endif /* CONFIG_ZONE_DMA */