Message-ID: <27af5964-6f5f-93f5-4db1-d4ecefff2c1e@oracle.com>
Date:   Thu, 23 Dec 2021 09:01:01 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v4 2/3] dma/pool: create dma atomic pool only if dma zone
 has managed pages
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de,
        cl@linux.com, kexec@lists.infradead.org, 42.hyeyoo@gmail.com,
        penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com,
        x86@kernel.org, bp@alien8.de,
        John Donnelly <john.p.donnelly@oracle.com>
References: <20211223094435.248523-1-bhe@redhat.com>
 <20211223094435.248523-3-bhe@redhat.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211223094435.248523-3-bhe@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUdVUDcrMTN2Y3BLbW05d1F6TnM5Q0xoM21yeEozV1BPaVVJeHhLS2pJb3F5?=
 =?utf-8?B?akUvTUFPaW43TWFoRXRacktXQ2sxOW1YZVZlL0hJMnFHaUJMbHNucElobmkw?=
 =?utf-8?B?YUpjMWYwWkVqQkV0REozV2ZKTlJyUHBZRnNlK3BSOElUKzAydEdWNWoyMnY1?=
 =?utf-8?B?SDJQZUlNVTFqa3J5WjRnVmdmWTk0alFkK1NnUmhBNGowYVBIV3QxMHhEYnZl?=
 =?utf-8?B?WHlTbWlCZjY2Ung3WnNGNC9UNis0N0FkRjdjZWR4TXh1b2ZFbk5MM0VWSHFJ?=
 =?utf-8?B?RVc3Z0J5NXdwUloya2R2VEN0dUQ5dVVGbzV1L3Z5akhuV2oxaEJMd1RhdEtE?=
 =?utf-8?B?MUtNa09aekowNFNITlZRYmJUbWx2NkJJdXN0T2RxS3hyTkdEak55ZVN2RUNo?=
 =?utf-8?B?Q1c2ckcyUVlDQ3NxZGFIbkE4eE5zVnh2Z01rcHg4dzZRbVRFeVJBSm5sVGhp?=
 =?utf-8?B?WUZUUEJVUkJHeVdHM0t1ZW56M2hnQlE2TXJVVGxBUW1YelhUd0lqYit4NE5T?=
 =?utf-8?B?Rm84V1NSS0lSem9mUFdORmY4NVpFVk56U0gxclM5TUlBSDduT2h0eDkwcERF?=
 =?utf-8?B?eEdMSXUxeHh4U05KWUQvOStsT3BBRElVQ0xKZHdvTnRkTk5FVTZPRnhyc0tz?=
 =?utf-8?B?SHYxOE50UGdXNkhqRHI4REJCKzRvdTZPN2gvRE1lVHNmSkdOVVVocWdCL2xP?=
 =?utf-8?B?QXYvcmJ2SHg4WE5nc0VnZ3p6T0twQURHV3hSU1U2TVI4ZktuMkpEM3RLaGNn?=
 =?utf-8?B?aWt4RkFCdUlpOG85dFVidjB0bEtXOTBId1IxdXF2RHIwaHlnU0Z2dmRCUDJV?=
 =?utf-8?B?NXZtd3FHZDB2TFBqbm1OdjBYaEJjV0JlQnBxVEhuT2w4bEJjT2lzN0NTay9w?=
 =?utf-8?B?OUY4RE14WEE5RGlZK2hnbCt4K0NZWlA3Qll6L1YweW9JZlNjZXJHNi9VNEFB?=
 =?utf-8?B?OXNXOU1aRkhiSUZGVjZZTmVvWGp3elZzTlR1am5EalRnMTFtMGZCa2JXeEsw?=
 =?utf-8?B?TFppSVoxYVEzSDI4NkNJSEpaMTF6Y082VVNMSWE1U0lOelFFd0g4NGw5eVAy?=
 =?utf-8?B?VjZnU3I2QXdOZmhPbkFvQ09ycjJCaE53eGd5dXV6aTNxTkJMbk1QeGt2SUJa?=
 =?utf-8?B?TU14YzE0MVFxRndDWWoxQldWVXRncFNEbFlKcVkzVUJWSDc3alJSZXRqQkFL?=
 =?utf-8?B?Q0FHdkhuZlFIRmcySjZTeFd1R0NBSHgzNHhWaTI3ZU4vN05uUCtONUErRmpo?=
 =?utf-8?B?TlFjdC80elpXR0FEbFdVWXZCOW1Hc1RDcXNWcnl3OU9ER0xpZGYzNnhCVmdS?=
 =?utf-8?B?OXhpdWI0YUNBQWdmSnFqUHFMYU4yUVRNb3pUMFB4cm0wU2xmbVRaNFJiaTVK?=
 =?utf-8?B?Z2FHampvWjRpNm9YcjdRaTZpT2NoMVE3VythYTlpdmtvK2lLbVY4VHNxUzM5?=
 =?utf-8?B?ZnByTnZlWndVWTdIU0YzWlVEc2xZQWRpMWxPbHJ6YU5vb1d2MjZLdkx6OVVa?=
 =?utf-8?B?c2R0L3VzbXB6MklQczd2Z2pYZnJMN3F2bEp0RitNbmlBakpuUE05QU5yZzlj?=
 =?utf-8?B?ZE5JTGRNc2RFalZ5VlFraTBySFJjdkxidXFYSWhSclJKbXFFZnNXRFZrNzc0?=
 =?utf-8?B?NE0wckhkRnVnK21jZVNnUGY4RU9nTUJTZDkwTjVZbFZvVFdhOE5HTHIrb05v?=
 =?utf-8?B?MlRLUlpGK2JCb0FkOEUxek1JK3d2S0dyUk9GWXVxSmJ4L0ttditoUk1kNGQ0?=
 =?utf-8?B?VWNUOWNaVzVnaFZlcFhtRWFlTkxVV245ZjByMnVJZEcxMlczOVhKeTZhUGVB?=
 =?utf-8?B?SU9lZkxOSWlnK2JGeU9ETDRuRExYY00wd1hnRDVrdVVEMHU5RnBRQnY2cmZB?=
 =?utf-8?B?UHRlVkdmK1ZESFUrQ0RvSUF0ZjdCajExdDZ1SWQwZVVSUndYM3FrWS9WWWd1?=
 =?utf-8?B?Z3QxUjRZTjEyUWhXOTdNb3lmT0R6TlQ0eEhYQ1ZicnpCeUtSRDFlL1Baa1Yr?=
 =?utf-8?B?N0NRS0Z0aFRnQ1M5TUxyZEIzanIreFRENDc4VXkwcEl3M3c0VUdFbmU2QUxa?=
 =?utf-8?B?dmZyblJ5Nm5zL3BPaFdRNzRkRXVhTTB0NDBqdyszaktSMGJuQ2xvb1hJeWlu?=
 =?utf-8?B?S1dJUG9zMWxFc251ak5CR3RZUUNiMHJBR3lzVXhIWUx5NFFpanNRWWRCNWV5?=
 =?utf-8?B?YmNRU3lURlhiNHVYVzJGK1ZYei9PSXJEZGN1bGhLL2JleTZ2Y0xIZjM2b0N6?=
 =?utf-8?B?dWQwNk1ta1pxeE1VZ1ZHZFJBUG1nPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a77f8283-afc2-409d-1d0d-08d9c6250fba
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2021 15:01:13.0518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fD064+Yc7HQaP9CAgbIrJK80tLvZ5ofbP8bgOS1YkFkaILJysrVDXfKihXO6d/IE2SeSp8DNQgQrH3Afave5moPmvgkvtdlXa2VK/iNrmx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1806
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10206 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112230081
X-Proofpoint-ORIG-GUID: E6Iwo1hsSW4kjCxJdzXvMgE_Njd7S-vk
X-Proofpoint-GUID: E6Iwo1hsSW4kjCxJdzXvMgE_Njd7S-vk
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/23/21 3:44 AM, Baoquan He wrote:
> Currently three dma atomic pools are initialized as long as the relevant
> kernel codes are built in. While in kdump kernel of x86_64, this is not
> right when trying to create atomic_pool_dma, because there's no managed
> pages in DMA zone. In the case, DMA zone only has low 1M memory presented
> and locked down by memblock allocator. So no pages are added into buddy
> of DMA zone. Please check commit f1d4d47c5851 ("x86/setup: Always reserve
> the first 1M of RAM").
> 
> Then in kdump kernel of x86_64, it always prints below failure message:
> 
>   DMA: preallocated 128 KiB GFP_KERNEL pool for atomic allocations
>   swapper/0: page allocation failure: order:5, mode:0xcc1(GFP_KERNEL|GFP_DMA), nodemask=(null),cpuset=/,mems_allowed=0
>   CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.13.0-0.rc5.20210611git929d931f2b40.42.fc35.x86_64 #1
>   Hardware name: Dell Inc. PowerEdge R910/0P658H, BIOS 2.12.0 06/04/2018
>   Call Trace:
>    dump_stack+0x7f/0xa1
>    warn_alloc.cold+0x72/0xd6
>    ? _raw_spin_unlock_irq+0x24/0x40
>    ? __alloc_pages_direct_compact+0x90/0x1b0
>    __alloc_pages_slowpath.constprop.0+0xf29/0xf50
>    ? __cond_resched+0x16/0x50
>    ? prepare_alloc_pages.constprop.0+0x19d/0x1b0
>    __alloc_pages+0x24d/0x2c0
>    ? __dma_atomic_pool_init+0x93/0x93
>    alloc_page_interleave+0x13/0xb0
>    atomic_pool_expand+0x118/0x210
>    ? __dma_atomic_pool_init+0x93/0x93
>    __dma_atomic_pool_init+0x45/0x93
>    dma_atomic_pool_init+0xdb/0x176
>    do_one_initcall+0x67/0x320
>    ? rcu_read_lock_sched_held+0x3f/0x80
>    kernel_init_freeable+0x290/0x2dc
>    ? rest_init+0x24f/0x24f
>    kernel_init+0xa/0x111
>    ret_from_fork+0x22/0x30
>   Mem-Info:
>   ......
>   DMA: failed to allocate 128 KiB GFP_KERNEL|GFP_DMA pool for atomic allocation
>   DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA32 pool for atomic allocations
> 
> Here, let's check if DMA zone has managed pages, then create atomic_pool_dma
> if yes. Otherwise just skip it.
> 
> Fixes: 6f599d84231f ("x86/kdump: Always reserve the low 1M when the crashkernel option is specified")
> Cc: stable@vger.kernel.org
> Signed-off-by: Baoquan He <bhe@redhat.com>
Acked-by: John Donnelly  <john.p.donnelly@oracle.com>

> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: iommu@lists.linux-foundation.org
> ---
>   kernel/dma/pool.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
> index 5a85804b5beb..00df3edd6c5d 100644
> --- a/kernel/dma/pool.c
> +++ b/kernel/dma/pool.c
> @@ -206,7 +206,7 @@ static int __init dma_atomic_pool_init(void)
>   						    GFP_KERNEL);
>   	if (!atomic_pool_kernel)
>   		ret = -ENOMEM;
> -	if (IS_ENABLED(CONFIG_ZONE_DMA)) {
> +	if (has_managed_dma()) {
>   		atomic_pool_dma = __dma_atomic_pool_init(atomic_pool_size,
>   						GFP_KERNEL | GFP_DMA);
>   		if (!atomic_pool_dma)
> @@ -229,7 +229,7 @@ static inline struct gen_pool *dma_guess_pool(struct gen_pool *prev, gfp_t gfp)
>   	if (prev == NULL) {
>   		if (IS_ENABLED(CONFIG_ZONE_DMA32) && (gfp & GFP_DMA32))
>   			return atomic_pool_dma32;
> -		if (IS_ENABLED(CONFIG_ZONE_DMA) && (gfp & GFP_DMA))
> +		if (atomic_pool_dma && (gfp & GFP_DMA))
>   			return atomic_pool_dma;
>   		return atomic_pool_kernel;
>   	}