Subject: Re: [PATCH] drivers:iio:dac make expression evaluation 64-bit
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Mihail Chindris <mihail.chindris@analog.com>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>,
        kernel-janitors <kernel-janitors@vger.kernel.org>
References: <YcIpAKV7Cmi0o7PU@debian-BULLSEYE-live-builder-AMD64>
 <CAHp75VcU8B8fydh874p6HpgGXXRYvNGdphH=i17JHB3DYJ1JZQ@mail.gmail.com>
 <eb59f405-24c6-69b8-beb1-465bfb783f61@collabora.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <16f84d86-4135-8a19-c5e1-3fbe8db78947@metafoo.de>
Date:   Thu, 23 Dec 2021 17:38:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <eb59f405-24c6-69b8-beb1-465bfb783f61@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 12/23/21 5:34 PM, Muhammad Usama Anjum wrote:
> On 12/22/21 11:49 PM, Andy Shevchenko wrote:
>> On Wed, Dec 22, 2021 at 5:59 PM Muhammad Usama Anjum
>> <usama.anjum@collabora.com> wrote:
>>> Two 32-bit values are being evaluated using 32-bit arithmetic and then
>>> passed to s64 type. It is wrong. Expression should be evaluated using
>>> 64-bit arithmetic and then passed.
>> ...
>>
>>>          dac->ch_data[ch].scale_dec = DIV_ROUND_CLOSEST((s64)rem * 1000000,
>>>                                                          65536);
>> Shouldn't the above be fixed as well? Has anybody tried to compile on
>> 32-bit arch this?
> No, it correct already. In this case, rem is being typecasted to s64 and
> then multiplied with a 32-bit number, 1000000. Thus 64-bit arithmetic is
> being performed here.

What Andy means is that this needs to be DIV_S64_ROUND_CLOSEST() to work 
on 32-bit platforms. But it is clearly unrelated to your change and 
should be in its own patch.