Date:   Thu, 23 Dec 2021 09:11:00 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Huangzhaoyang <huangzhaoyang@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: remove judgement based on gfp_flags
Message-ID: <20211223091100.4a86188f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <1640224567-3014-1-git-send-email-huangzhaoyang@gmail.com>
References: <1640224567-3014-1-git-send-email-huangzhaoyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 23 Dec 2021 09:56:07 +0800 Huangzhaoyang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> 
> The parameter allocation here is used for indicating if the memory
> allocation can stall or not. Since we have got the skb buffer, it
> doesn't make sense to check if we can yield on the net's congested
> via gfp_flags. Remove it now.

This is checking if we can sleep AFAICT. What are you trying to fix?

> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 4c57532..af5b6af 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1526,7 +1526,7 @@ int netlink_broadcast(struct sock *ssk, struct sk_buff *skb, u32 portid,
>  	consume_skb(info.skb2);
>  
>  	if (info.delivered) {
> -		if (info.congested && gfpflags_allow_blocking(allocation))
> +		if (info.congested)
>  			yield();
>  		return 0;
>  	}