Date:   Thu, 23 Dec 2021 18:26:56 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Bard Liao <yung-chuan.liao@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, vkoul@kernel.org,
        vinod.koul@linaro.org, linux-kernel@vger.kernel.org, tiwai@suse.de,
        gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org,
        pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
        bard.liao@intel.com
Subject: Re: [PATCH 7/7] soundwire: intel: remove PDM support
Message-ID: <YcS/cPb0UXsc9SWm@sirena.org.uk>
References: <20211213054634.30088-1-yung-chuan.liao@linux.intel.com>
 <20211213054634.30088-8-yung-chuan.liao@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oH+CFB7uVqhnu6IS"
Content-Disposition: inline
In-Reply-To: <20211213054634.30088-8-yung-chuan.liao@linux.intel.com>
Precedence: bulk


--oH+CFB7uVqhnu6IS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>=20
> While the hardware supports PDM streams, this capability has never
> been tested or enabled on any product, so this is dead-code. Let's
> remove all this.

This doesn't build with current code, I'm guessing due to a Soundwire
dependency I don't have:

/mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct snd_soc_=
dai_ops' has no member named 'set_sdw_stream'; did you mean 'set_stream'?
 1142 |  .set_sdw_stream =3D intel_pdm_set_sdw_stream,
      |   ^~~~~~~~~~~~~~
      |   set_stream
/mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of 'in=
t (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct snd_so=
c_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_dai *, voi=
d *, int)' [-Werror=3Dincompatible-pointer-types]
 1142 |  .set_sdw_stream =3D intel_pdm_set_sdw_stream,
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization f=
or 'intel_pdm_dai_ops.hw_params')
/mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct snd_soc_=
dai_ops' has no member named 'get_sdw_stream'; did you mean 'get_stream'?
 1143 |  .get_sdw_stream =3D intel_get_sdw_stream,
      |   ^~~~~~~~~~~~~~
      |   get_stream
/mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of 'in=
t (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible =
pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=3Dincompatibl=
e-pointer-types]
 1143 |  .get_sdw_stream =3D intel_get_sdw_stream,
      |                    ^~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization f=
or 'intel_pdm_dai_ops.hw_free')
cc1: all warnings being treated as errors
make[3]: *** [/mnt/kernel/scripts/Makefile.build:287: drivers/soundwire/int=
el.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire] Er=
ror 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:219: __sub-make] Error 2

--oH+CFB7uVqhnu6IS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHEv28ACgkQJNaLcl1U
h9COhQf/XJITxI7uwmAdAs5euRIHx45jbk3mP4sDaiWxN/zxKpNsUhk9g1K/aBuo
Vcdo0H4FKTG5R/PvxRC14VTcDd3NexCOqmUgDxsR6WP0DLNqYPSYO+2RcHqWv/zb
MMpn3TIgNO4nGEmIrLaygph/u4t814+TUlCD8wjnXdkJgzXwwXk2EcrHfibCOetX
9WWWRB59W5ULjHVveRjxdYzRakTpLNAmthvU0R7OdfLcXW/u8v9rHmN4TAhXvx9w
wK7gabo+1fU16VIiNUSVLcwhVRbcyijIPPU6n0T7oiGbgQgVi0a/ihCUa+MHAYn5
4MZMyaEPEwOOaHmnZuS43gmkq7y8eQ==
=abL6
-----END PGP SIGNATURE-----

--oH+CFB7uVqhnu6IS--