Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32CBC4332F for ; Thu, 23 Dec 2021 19:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350076AbhLWTcF (ORCPT ); Thu, 23 Dec 2021 14:32:05 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40820 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350022AbhLWTcB (ORCPT ); Thu, 23 Dec 2021 14:32:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GTJhaj2XCJscWkNa8lKeeUxD0omZidYOBZ+2c/Vg/no=; b=1/yxUF96lAwfOfZzel2ujl/6ug aZx4seCY/5ibhrMZ+mEdvMlMN5+tVOhjVYxQNqqInie4nk+K61GS85UJXRGT9LWFNWDx8etExiSEZ Qay0a7rnCaGunGW3SBkZR1nukreOndyGkNNL5SwlToEmXTMqq8BgPP9+ZK1cjIUJLM8g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n0ToT-00HJzO-HZ; Thu, 23 Dec 2021 20:31:41 +0100 Date: Thu, 23 Dec 2021 20:31:41 +0100 From: Andrew Lunn To: Florian Fainelli Cc: devicetree@vger.kernel.org, Arnd Bergmann , Olof Johansson , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Stephen Rothwell , Linus Walleij , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Rob Herring , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH] dt-bindings: net: dsa: Fix realtek-smi example Message-ID: References: <20211223181741.3999-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211223181741.3999-1-f.fainelli@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 23, 2021 at 10:17:41AM -0800, Florian Fainelli wrote: > The 'ports' node is not supposed to have a 'reg' property at all, in > fact, doing so will lead to dtc issuing warnings looking like these: > > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:109.4-14: Warning (reg_format): /switch/ports:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #address-cells value > arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts:106.9-149.5: Warning (avoid_default_addr_size): /switch/ports: Relying on default #size-cells value > > Fix the example by remove the stray 'reg' property. > > Reported-by: Stephen Rothwell > Fixes: 3b3b6b460f78 ("net: dsa: Add bindings for Realtek SMI DSAs") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew